mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Visibility of Shelves menu item with custom permissions #974
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Bolthier on GitHub (Dec 29, 2018).
Originally assigned to: @ssddanbrown on GitHub.
Describe the bug
The visibility of the Shelves menu item is dependent only on global permission of a user role. With custom permissions only set to View for the same user role the menu item doesn't show up.
Steps To Reproduce
Expected behavior
A tab for the Shelves if you have custom permissions for View on specific shelves even without any default permissions.
Or an option in Settings or Users where you can activate or deactivate the button.
Your Configuration (please complete the following information):
Additional context
See also: https://github.com/BookStackApp/BookStack/issues/1171#issuecomment-446378261
@ssddanbrown commented on GitHub (Jan 1, 2019):
@Bolthier Good find, Thanks for reporting.
Has very similar functionality requirements as #1199.
@ssddanbrown commented on GitHub (Mar 10, 2019):
Patch applied to master, Will be in the next patch release.