mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Update modal windows and dropdowns to close on esc key press #970
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @BeckerFelix on GitHub (Dec 25, 2018).
Describe the feature you'd like
I'd like to be able to close and save the code block window by keystroke. E.g. esc or enter. I love the shortcuts but as far as I see, there is no assignment for this action.
Describe the benefits this feature would bring to BookStack users
Simplification in workflow, no need to grab the mouse and aim for the save code button.
@BeckerFelix commented on GitHub (Dec 25, 2018):
Actually by default, windows or menus should close with esc. For example having dropped-down the Formats selection in WYSIWYG editor, it seems natural to me to abort by esc keystroke.
@ssddanbrown commented on GitHub (Aug 26, 2019):
As of the next release, v0.27, you should be able to close all BookStack native dropdowns and modal windows using the escape key. Unfortunately, The WYSIWYG editor dropdowns are harder to modify so won't yet get this functionality.
@ssddanbrown commented on GitHub (May 16, 2022):
With the update of the editor in v22.02 it looks like this has now been achieved, Will therefore close this off.