mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-07 03:09:44 +03:00
Role Admin can be removed from user Admin #908
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Bolthier on GitHub (Nov 14, 2018).
Describe the bug
While the role admin can not be restricted it is possible to remove the user Admin from this role.
Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
Error Message "You can't remove the role Admin for this user." or "At least one user must inherit the role Admin." or a gray box before role Admin.
Similar to the way the permissions of the role Admin cannot be altered it shouldn't be allowed to remove the role Admin from the user admin. It should only be possible to add other roles.
For better understanding the permanent permissions set for the role Admin should be grayed out too.
Screenshots
Your Configuration (please complete the following information):
Related but not sames issues:
https://github.com/BookStackApp/BookStack/issues/834
https://github.com/BookStackApp/BookStack/issues/977
@lommes commented on GitHub (Dec 5, 2018):
@ssddanbrown How are you planning to implement this?
It is of course usefull to remove the Admin role from users and there might even be valid use cases where it is intended to remove the role from the currently authenticated user (especially together with ldap group sync). There still is
php artisan bookstack:create-adminto fix this@ssddanbrown commented on GitHub (Dec 5, 2018):
@lommes I was thinking about just adding a check to see if the user is the only remaining admin user, then throw an error if so. So the current user can still remove the role from themselves if there's another admin in the system.