mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Feature: Permalinks #87
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @the-guernic on GitHub (Apr 3, 2016).
Hey, I really love what you did here, because it gives an structure to a wiki than just a search engine.
One thing I would really like to see, would be a permalink solution, tho.
As far as I can tell the only way to link pages to each other is by using their static link. But if a book or a chapter is renamed the link will be dead.
Or am I missing something here?
Thanks in advance.
@ssddanbrown commented on GitHub (Apr 3, 2016):
Hi @the-guernic, Thanks! I'm glad you're liking BookStack.
You are partially correct, The URL of a page includes the book name so, If the book name is changed, the link will no longer function in the same way. As of v0.7.5, when a page is updated the book name is recorded via the revision system. If a page is then not found the revisions will be searched. If a matching revision is found (Using the old url) the user will then be redirected to the new url of that same page. This should catch most name changes except for edge cases such as when an old book name is re-used by a new book.
There is also a static link system for pages but it's not instantly obvious. When you select some text on a page you will get a little pop-up with a url and copy button. That url is a permalink to the ID of that page (Which is not affected by any name changes). That url will also link to the exact block of content that was highlighted.
Here's an image of that popup:
I do want to go through and document all these little features at some point. Hopefully soon now I've started the documentation pages 😄
@the-guernic commented on GitHub (Apr 4, 2016):
AAAH! I had not noticed that! Thank you for the heads up!
Thanks for the fast response, too :)
Just out of curiosity: I tried to translate your script to german but noticed, that some of the strings are hardcoded into the blade templates. Do you plan to add localization support in the future?
Cheers!
@ssddanbrown commented on GitHub (Apr 4, 2016):
@the-guernic No worries! I have opened an issue on the docs to document this better so I will therefore go ahead and close this issue.
In regards to the translations, Yes, that would definitely be something I would like to support. Laravel has a nice translation system built in which we can use when the time comes. I made some changes with some of the JavaScript driven components a while back to ensure we'll still be able to use the Laravel translation system with ease in the future.
Unfortunately I only know English and development of large new features is still fairly rapid. Once things have become a little more stable and the project hopefully has more followers then I'll make localization a higher priority.