mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Remove view permissions from a permission-less Role #85
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ssddanbrown on GitHub (Mar 31, 2016).
At the moment a role with no permissions still has view permissions (Since there are no view permissions currently on a role level). Adding view permission control to roles will allow you to have very 'unprivileged' roles which then you can 'whitelist' on specific assets to allow very controlled access.
This is a spin off from the changes in issue #89.
@ssddanbrown commented on GitHub (Apr 9, 2016):
Removed this from being targeted in the next release. Realised that some major work needs to be done to re-write the permission system to be more maintainable and flexible.
Currently the role permission and entity permissions cannot easily be queried together and are checked with code. I want to combine these permissions into some kind of 'permission reference' table for faster and simpler querying.
@ssddanbrown commented on GitHub (May 12, 2016):
Now complete with new permission system, Will be in next release.