mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Assign div class to pages and chapters #831
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @admish on GitHub (Sep 25, 2018).
Describe the feature you'd like
Give chapters and pages a unique
div classto define them so custom CSS can be applied to distinguish them differently.Describe the benefits this feature would bring to BookStack users
Titles, pages, and chapters, all use the
h1tag for their titles but they don't fall within their own CSS elements. Changes to this CSS class in the Custom HTML head content settings affects every title within the book regardless of how they are used (excluding the book title which uses<h1 style="font-size: 4.8em">).Assigning these classes would also allow users to customize chapter title pages or simply remove those pages and keep them in the backend for organization. They could change the spacing between pages, incorporate artwork or a simple
hrtag instead of a full page break. I think overall this small change could go very far among those that like to modify their css.Additional context
I really just wanted to remove
<div class="page-break"></div>from chapters and center theh1so it just runs right into page 1 of that chapter. I can't remove those page breaks without removing all page breaks.@ssddanbrown commented on GitHub (Sep 27, 2018):
Thanks @admish for this request.
Just to confirm, since there is mention of page-breaks, Is this request primarily targeted for exports?
Just checking since export content is handled a little different from in-app content.
@admish commented on GitHub (Sep 27, 2018):
My request is targeted to how elements are named or nested, so CSS can be used to make changes to one thing that don't cascade through the entire book.
I'm using the version you pushed in issue #981 that lets export content use CSS
@Froggy422811 commented on GitHub (Jun 21, 2023):
Hi @ssddanbrown ,
I would like to raise this issue again, although it is a bit older. For me, it's currently about exporting to PDF.
I have already used the Custom Theme feature to create an appealing formatting for the export. Currently, for example, I am concerned with formatting the headings with a numbering. Unfortunately, there is no class definition for e.g. the book title when exporting a complete book.
For my understanding - I would now need to copy file 'resources/views/exports/book.blade.php' to my custom theme folder and adjust it at the following location:
And I could do this analogously with the file 'resources/views/exports/chapter.blade.php'. For the output of a page then the file 'resources/views/pages/parts/page-display.blade.php' would be adapt.
Is this the suggested approach or shouldn't something like this be implemented in general?
Sorry, I'm not a professional developer. Just an experienced user.
@ssddanbrown commented on GitHub (Jun 21, 2023):
@Froggy422811
Yes to both, in a way.
The theme system is there to allow anything not officially implemented/supported.
Otherwise, having specific content type classes could be useful but there's been relatively little demand. Not something I'd object to adding though, and not something tricky to add, just needs sensible class naming/placement along with some tests to cover. We have existing export helper classes so it's not a new paradigm being added.
If you do this via the custom theme, be careful with
page-display.blade.php, that's also used for normal non-export use.I think you'd need to override the three
resources/views/exports/*.blade.phpfiles, in addition to the tworesources/views/exports/parts/*-item.blade.phpfiles.