mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Pasting from excel produces image instead of table #797
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pth0rn on GitHub (Aug 25, 2018).
I noticed that pasting from Excel, either into a blank space in Bookstack or table, uploads an image of the cells. Is this the intended behavior? I tried the same thing into a TinyMCE demo on their website, and that instead produces a table like you'd expect
@TBK commented on GitHub (Aug 25, 2018):
BookStack is using TinyMCE 4.7.9, the latest version i 4.8.2.
I think the issue you experienced is related to this bug "fixed a bug in the Table Plugin where some table cell styles were not correctly added to the content html." which was fixed in version 4.7.10 - https://www.tiny.cloud/docs/changelog/#version4710april32018
@ssddanbrown commented on GitHub (Aug 25, 2018):
Hmm, Not the intended behaviour.
In BookStack we do have a custom paste listener to check the clipboard for images, so we can handle paste-image uploads, then prevent further action. Can only image Excel now adds screenshot-style image data to the clipboard along with the standard data. Will have a deeper look.
If possible please confirm your OS and Excel version.
@pth0rn commented on GitHub (Aug 25, 2018):
This on Windows 10 with Excel 2016.
I just checked the Copy options in Excel and there are 2 options -- "Copy" and "Copy as Picture".
However regular copy must also include image data on the clipboard cause the paste handler still uploads an image using that.
Work around for me would just pasting to Google sheets or the like, and copying from that.
Thanks!
@yamss commented on GitHub (Mar 26, 2019):
Just to confirm, I have the same issue in Linux Mint 19 and LibreOffice Calc 5.1.6.2 . Using Google docs or ONLYOFFICE works as a work around.
@antontkv commented on GitHub (May 14, 2019):
Have the same problem on Excel and LibreOffice.
@ssddanbrown commented on GitHub (May 15, 2019):
Thanks everyone above for the details. Potential fix now applied in master, Will be in the next release. Fix tested on ubuntu+Libre office. Should be the same result in excel.
If this is still not fixed fro you after upgrading to v0.26.2 (once it's released) please let me know and I'll investigate further.