mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-06 00:59:39 +03:00
Dropdown list on book/chapter/page view doesn't expand correctly #772
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @vasiliev123 on GitHub (Aug 13, 2018).
Originally assigned to: @Abijeet on GitHub.
Describe the bug
After clicking on the dropown page list (no matter which) in the book/chapter/page view, it collapses correctly. However when I click to expand the menu, sometimes it works and sometimes it expands and quickly collapses (see screenshots section, dropdown triangle under Chapter 1 shows the list should be expanded but it isn't).
I checked only on 2 browsers:
Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
I would like to see expanded content :)
Screenshots
Book view
Page view
Your Configuration (please complete the following information):
@Kdecherf commented on GitHub (Aug 28, 2018):
Confirmed here on 0.23.2. Could be related to the position of the opened page in the menu:
I'm seeing this bug when trying to expand the chapter containing the current opened page.
@Abijeet commented on GitHub (Sep 16, 2018):
Can reproduce, will work on a fix.
@Abijeet commented on GitHub (Sep 16, 2018):
Hi @vasiliev123,
Thanks for reporting this issue.
I was only able to reproduce this when clicking on these multiple times, and by double clicking them. This seems to be happening due to a race condition on quick mouse clicks.
@vasiliev123 commented on GitHub (Sep 17, 2018):
I don't have to do it fast :)
After fresh reload:
@Abijeet commented on GitHub (Sep 17, 2018):
@vasiliev123 - Are you double clicking? This happens for me only if I click on the item again when its in the process of animation
@vasiliev123 commented on GitHub (Sep 17, 2018):
@Abijeet nope, these are single clicks every after about 2 seconds. As you can also see I've changed css a little bit (I've deleted the margins), of course I've double checked (about month ago) without any modifications :) problem still persisted. However I will make sure one more time tomorrow and post my results.
@ssddanbrown commented on GitHub (Sep 22, 2018):
@Abijeet From my play-around this could occur easily as shown above when in Firefox & when the list was open by default (In the page sidebar). Your fix did seem to fix this though so have merged, Thanks.
I've tried to make a little smoother and consistent in FireFox by animating max-height and delaying animation start but not sure I've made much difference.
Overall, The main issue here should be fixed in the next release.