mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Code Blocks are not getting wrapped in revision diffs #717
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @watschi on GitHub (Jun 15, 2018).
Expected Behavior
When viewing diffs of different site revisions code blocks should get wrapped
Current Behavior
Code blocks don't get rendered correctly when viewing a diff
Steps to Reproduce
Change something in a code block an view the changes in revision history
@Abijeet commented on GitHub (Jun 17, 2018):
Can reproduce on demo. I think codemirror is not being initialized on revision pages.
@ssddanbrown commented on GitHub (Jun 17, 2018):
Yeah, Codemirror instances won't run on diffs but I don't think they should in that case since it'll remove any diff highlighting which I'd consider more important in this view.
I think instead we just need to add styling to wrap these on diffs. I think we already do this for exports.