mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
UI: Comments - Inline code - Exceeds the comments container #694
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sai-manoharp on GitHub (May 27, 2018).
For Bug Reports
Expected Behavior
Comment content should not cross the container
Current Behavior
Inline code block - exceeds the comments container.
Steps to Reproduce
Change the styles to break the words in the code block.
Attached screenshot:
@ssddanbrown commented on GitHub (May 28, 2018):
Hi @manohar566,
Thanks for reporting this and offering a pull request.
Note that after a page reload the code block should be parsed by codemirror to be in a scrollable code-block anyway as shown here:
I'm hesitant to merge in your changes in #861 due to the fact the changes will mean white-space is not preserved in the code-block which I think it pretty essential for code-based content.
@sai-manoharp commented on GitHub (May 28, 2018):
Hi @ssddanbrown,
Thanks for pointing that out. I'll make the necessary change and push back soon.
@ssddanbrown commented on GitHub (Nov 10, 2018):
Since the last comment on this issue is relatively old I'm going to close this. If the issue remains and is something you still require to be fixed please comment and this can be reopened if required.