mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-05-04 18:08:46 +03:00
[PR #5912] More flexible OIDC key support #6592
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/BookStackApp/BookStack/pull/5912
Author: @McTom234
Created: 11/23/2025
Status: 🔄 Open
Base:
development← Head:oidc-key-algorithms📝 Commits (1)
743657dfeat(auth/oidc): wider key algorithm support📊 Changes
4 files changed (+34 additions, -7 deletions)
View changed files
📝
app/Access/Oidc/OidcJwtSigningKey.php(+14 -3)➕
app/Access/Oidc/OidcJwtSigningKeyAlgorithm.php(+16 -0)📝
app/Access/Oidc/OidcJwtWithClaims.php(+2 -2)📝
app/Access/Oidc/OidcProviderSettings.php(+2 -2)📄 Description
The goal of this PR is to allow more key algorithms for OIDC signing keys.
The concerns regarding such implementation in #5390 were considered. I try to address them by allowing a flexible, extensible, and somewhat maintainable approach, which I gratefully take feedback on and am willing to improve by the feedback provided.
Therefore, the issue with this PR is not the few lines of code changed but the architecture of how more key algorithms could be supported. For presentation reasons, I added the RS512 algorithm, which I had done before.
If the suggested approach would be considered by the maintainers, I needed some support to extend and test this with more common algorithms like ES256 as described in the issue mentioned above.
Besides that, the test suits would probably need at least a test case per key algorithm to confirm that the implementations are working, which is currently a ToDo.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.