[PR #5899] [MERGED] Exports: Updated perm checking for images in ZIP exports #6588

New Issue

OVERLORD · 2026-02-05T10:36:13+03:00

OVERLORD commented

2026-02-05 10:36:13 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5899
Author: @ssddanbrown
Created: 11/18/2025
Status: ✅ Merged
Merged: 11/18/2025
Merged by: @ssddanbrown

Base: development ← Head: zip_image_handling

📝 Commits (1)

aaa2818 Exports: Updated perm checking for images in ZIP exports

📊 Changes

5 files changed (+113 additions, -26 deletions)

View changed files

📝 app/Exports/ZipExports/ZipExportReferences.php (+13 -3)
📝 app/Uploads/Image.php (+8 -8)
📝 app/Uploads/ImageService.php (+35 -15)
📝 app/Uploads/ImageStorage.php (+9 -0)
📝 tests/Exports/ZipExportTest.php (+48 -0)

📄 Description

For #5885
Adds to, uses and cleans-up central permission checking in ImageService to mirror that which would be experienced by users in the UI to result in the same image access conditions.

Adds testing to cover.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5899 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 11/18/2025 **Status:** ✅ Merged **Merged:** 11/18/2025 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `zip_image_handling` --- ### 📝 Commits (1) - [`aaa2818`](https://github.com/BookStackApp/BookStack/commit/aaa28186bc0dff12c38f4627dac2034fa9ddb63d) Exports: Updated perm checking for images in ZIP exports ### 📊 Changes **5 files changed** (+113 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `app/Exports/ZipExports/ZipExportReferences.php` (+13 -3) 📝 `app/Uploads/Image.php` (+8 -8) 📝 `app/Uploads/ImageService.php` (+35 -15) 📝 `app/Uploads/ImageStorage.php` (+9 -0) 📝 `tests/Exports/ZipExportTest.php` (+48 -0) </details> ### 📄 Description For #5885 Adds to, uses and cleans-up central permission checking in ImageService to mirror that which would be experienced by users in the UI to result in the same image access conditions. Adds testing to cover. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:36:13 +03:00

OVERLORD closed this issue

2026-02-05 10:36:17 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6588