starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-02-25 03:10:24 +03:00
Code Issues 784 Packages Projects Releases 14 Wiki Activity

[PR #5768] [CLOSED] Enhance video attachment support with preview and embed functionality #6564

New Issue
Closed
opened 2026-02-05 10:35:39 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 10:35:39 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5768
Author: @vincenzopirozzideveloper
Created: 8/19/2025
Status: ❌ Closed

Base: development ← Head: feature/improved-video-attachments

📝 Commits (1)

  • b12b404 Enhance video attachment support with preview and embed functionality

📊 Changes

11 files changed (+504 additions, -18 deletions)

View changed files

📝 app/Uploads/Attachment.php (+37 -3)
📝 app/Uploads/Controllers/AttachmentController.php (+63 -1)
➕ database/migrations/2024_01_15_add_video_metadata_to_attachments.php (+30 -0)
📝 lang/en/common.php (+1 -0)
📝 lang/en/entities.php (+1 -0)
📝 resources/js/components/index.ts (+1 -0)
➕ resources/js/components/video-preview.js (+100 -0)
➕ resources/sass/components/_video-preview.scss (+222 -0)
📝 resources/sass/styles.scss (+1 -0)
📝 resources/views/attachments/list.blade.php (+27 -9)
📝 resources/views/attachments/manager-list.blade.php (+21 -5)

📄 Description

Summary

This PR introduces improved support for video attachments:

  • Inline preview modal with responsive <video> player.
  • Embed option in editor toolbox.
  • HTTP Range support for efficient streaming & seeking.
  • New migration for storing mime_type, metadata and file_size.
  • Updated UI icons and i18n strings for video actions.

Notes

  • Supported formats: mp4, webm, mkv, ogg, avi, mov, m4v.
  • Changes are backward compatible (nullable DB columns).
  • Frontend additions: VideoPreview component and styles.

Screenshots

modal-video preview-button preview-button-2

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5768 **Author:** [@vincenzopirozzideveloper](https://github.com/vincenzopirozzideveloper) **Created:** 8/19/2025 **Status:** ❌ Closed **Base:** `development` ← **Head:** `feature/improved-video-attachments` --- ### 📝 Commits (1) - [`b12b404`](https://github.com/BookStackApp/BookStack/commit/b12b4042a03a006a507907735f1f71817c285c0e) Enhance video attachment support with preview and embed functionality ### 📊 Changes **11 files changed** (+504 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `app/Uploads/Attachment.php` (+37 -3) 📝 `app/Uploads/Controllers/AttachmentController.php` (+63 -1) ➕ `database/migrations/2024_01_15_add_video_metadata_to_attachments.php` (+30 -0) 📝 `lang/en/common.php` (+1 -0) 📝 `lang/en/entities.php` (+1 -0) 📝 `resources/js/components/index.ts` (+1 -0) ➕ `resources/js/components/video-preview.js` (+100 -0) ➕ `resources/sass/components/_video-preview.scss` (+222 -0) 📝 `resources/sass/styles.scss` (+1 -0) 📝 `resources/views/attachments/list.blade.php` (+27 -9) 📝 `resources/views/attachments/manager-list.blade.php` (+21 -5) </details> ### 📄 Description ### Summary This PR introduces improved support for video attachments: - Inline preview modal with responsive `<video>` player. - Embed option in editor toolbox. - HTTP Range support for efficient streaming & seeking. - New migration for storing `mime_type`, `metadata` and `file_size`. - Updated UI icons and i18n strings for video actions. ### Notes - Supported formats: mp4, webm, mkv, ogg, avi, mov, m4v. - Changes are backward compatible (nullable DB columns). - Frontend additions: `VideoPreview` component and styles. ### Screenshots <img width="2555" height="1269" alt="modal-video" src="https://github.com/user-attachments/assets/f2150a8f-3731-4deb-a58f-38d8b16ada08" /> <img width="464" height="414" alt="preview-button" src="https://github.com/user-attachments/assets/06cee070-45b5-4d0c-a07f-8a6e4485d298" /> <img width="2555" height="842" alt="preview-button-2" src="https://github.com/user-attachments/assets/e8b5a6a4-f311-4a45-a3b9-0d96a0963d44" /> --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:35:39 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6564
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?