[PR #5725] [MERGED] MarkDown Editor: TypeScript Conversion & Plaintext Editor #6555

Closed
opened 2026-02-05 10:35:27 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5725
Author: @ssddanbrown
Created: 7/21/2025
Status: Merged
Merged: 7/23/2025
Merged by: @ssddanbrown

Base: developmentHead: md_plaintext


📝 Commits (10+)

  • 7bbf591 MD Editor: Starting conversion to typescript
  • 61adc73 MD Editor: Finished conversion to Typescript
  • ec07793 MD Editor: Started work on input interface
  • 5ffec2c MD Editor: Updated actions to use input interface
  • 6b4b500 MD Editor: Added plaintext input implementation
  • d55db06 MD Editor: Added plaintext/cm switching
  • 6621d55 MD Editor: Worked to improve/fix positioning code
  • 7ca8bdc MD Editor: Added custom textarea undo/redo, updated positioning methods
  • 53f3284 MD Editor: Last tests/check over plaintext use/switching
  • 3b9c0b3 MD Editor: Fixed plaintext dark styles, updated npm packages

📊 Changes

33 files changed (+1457 additions, -881 deletions)

View changed files

📝 dev/build/esbuild.js (+1 -1)
📝 lang/en/entities.php (+1 -0)
📝 package-lock.json (+392 -325)
📝 package.json (+1 -0)
📝 resources/js/components/entity-selector-popup.ts (+20 -20)
📝 resources/js/components/entity-selector.ts (+44 -38)
📝 resources/js/components/image-manager.js (+4 -0)
📝 resources/js/global.d.ts (+3 -1)
📝 resources/js/markdown/actions.ts (+129 -233)
resources/js/markdown/codemirror.ts (+54 -0)
resources/js/markdown/common-events.js (+0 -32)
resources/js/markdown/common-events.ts (+36 -0)
📝 resources/js/markdown/display.ts (+42 -36)
📝 resources/js/markdown/dom-handlers.ts (+23 -40)
resources/js/markdown/index.mjs (+0 -51)
resources/js/markdown/index.mts (+71 -0)
resources/js/markdown/inputs/codemirror.ts (+128 -0)
resources/js/markdown/inputs/interface.ts (+81 -0)
resources/js/markdown/inputs/textarea.ts (+315 -0)
📝 resources/js/markdown/markdown.ts (+5 -6)

...and 13 more files

📄 Description

Conversion of the MD editor code to typescript, and the addition of a plaintext-based editor input area instead of codemirror (optional on toggle).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5725 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 7/21/2025 **Status:** ✅ Merged **Merged:** 7/23/2025 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `md_plaintext` --- ### 📝 Commits (10+) - [`7bbf591`](https://github.com/BookStackApp/BookStack/commit/7bbf591a7fdb46bb0da30669354b8768ac950506) MD Editor: Starting conversion to typescript - [`61adc73`](https://github.com/BookStackApp/BookStack/commit/61adc735c8d525907dbb8b1b554c24d303cec229) MD Editor: Finished conversion to Typescript - [`ec07793`](https://github.com/BookStackApp/BookStack/commit/ec07793cda66d319bf716ef3dcbbe2fe19f0c355) MD Editor: Started work on input interface - [`5ffec2c`](https://github.com/BookStackApp/BookStack/commit/5ffec2c52d6b6c1cf61e53813fe4bfbece3da1aa) MD Editor: Updated actions to use input interface - [`6b4b500`](https://github.com/BookStackApp/BookStack/commit/6b4b500a3313f30c92a8a6ffa1d8427fdf4d2aaa) MD Editor: Added plaintext input implementation - [`d55db06`](https://github.com/BookStackApp/BookStack/commit/d55db06c01302c8a2e597c91620fbfb8ddfc6982) MD Editor: Added plaintext/cm switching - [`6621d55`](https://github.com/BookStackApp/BookStack/commit/6621d55f3d2248a273554c0f780dbeef465e6b15) MD Editor: Worked to improve/fix positioning code - [`7ca8bdc`](https://github.com/BookStackApp/BookStack/commit/7ca8bdc23172c258fe1466d803e4992a3551ee06) MD Editor: Added custom textarea undo/redo, updated positioning methods - [`53f3284`](https://github.com/BookStackApp/BookStack/commit/53f32849a9fceefab4bc2029c3b7790655184861) MD Editor: Last tests/check over plaintext use/switching - [`3b9c0b3`](https://github.com/BookStackApp/BookStack/commit/3b9c0b34ae811d14ae39d014fc9e427dafe8aad5) MD Editor: Fixed plaintext dark styles, updated npm packages ### 📊 Changes **33 files changed** (+1457 additions, -881 deletions) <details> <summary>View changed files</summary> 📝 `dev/build/esbuild.js` (+1 -1) 📝 `lang/en/entities.php` (+1 -0) 📝 `package-lock.json` (+392 -325) 📝 `package.json` (+1 -0) 📝 `resources/js/components/entity-selector-popup.ts` (+20 -20) 📝 `resources/js/components/entity-selector.ts` (+44 -38) 📝 `resources/js/components/image-manager.js` (+4 -0) 📝 `resources/js/global.d.ts` (+3 -1) 📝 `resources/js/markdown/actions.ts` (+129 -233) ➕ `resources/js/markdown/codemirror.ts` (+54 -0) ➖ `resources/js/markdown/common-events.js` (+0 -32) ➕ `resources/js/markdown/common-events.ts` (+36 -0) 📝 `resources/js/markdown/display.ts` (+42 -36) 📝 `resources/js/markdown/dom-handlers.ts` (+23 -40) ➖ `resources/js/markdown/index.mjs` (+0 -51) ➕ `resources/js/markdown/index.mts` (+71 -0) ➕ `resources/js/markdown/inputs/codemirror.ts` (+128 -0) ➕ `resources/js/markdown/inputs/interface.ts` (+81 -0) ➕ `resources/js/markdown/inputs/textarea.ts` (+315 -0) 📝 `resources/js/markdown/markdown.ts` (+5 -6) _...and 13 more files_ </details> ### 📄 Description Conversion of the MD editor code to typescript, and the addition of a plaintext-based editor input area instead of codemirror (optional on toggle). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:35:27 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6555