[PR #5676] [MERGED] New WYSIWYG editor for comments & descriptions #6543

New Issue

OVERLORD · 2026-02-05T10:35:09+03:00

OVERLORD commented

2026-02-05 10:35:09 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5676
Author: @ssddanbrown
Created: 6/24/2025
Status: ✅ Merged
Merged: 7/9/2025
Merged by: @ssddanbrown

Base: development ← Head: lexical_comments

📝 Commits (5)

c606970 Lexical: Started comment implementation
b80992c Comments: Switched to lexical editor
02a35b6 Lexical: Added new WYSIWYG to chapter/book/shelf descriptions
0544751 Lexical: Added some styling and tweaks for basic editors
a37d0c5 Tests: Updated comment test to account for new editor usage

📊 Changes

26 files changed (+388 additions, -313 deletions)

View changed files

📝 app/Util/HtmlDescriptionFilter.php (+3 -3)
📝 resources/js/components/page-comment.ts (+16 -18)
📝 resources/js/components/page-comments.ts (+15 -18)
➖ resources/js/components/wysiwyg-input.js (+0 -23)
➕ resources/js/components/wysiwyg-input.ts (+32 -0)
📝 resources/js/wysiwyg-tinymce/config.js (+0 -48)
📝 resources/js/wysiwyg/index.ts (+104 -44)
📝 resources/js/wysiwyg/nodes.ts (+10 -4)
📝 resources/js/wysiwyg/ui/defaults/toolbars.ts (+69 -44)
📝 resources/js/wysiwyg/ui/framework/core.ts (+16 -1)
📝 resources/js/wysiwyg/ui/framework/decorator.ts (+1 -1)
📝 resources/js/wysiwyg/ui/framework/helpers/dropdowns.ts (+11 -4)
📝 resources/js/wysiwyg/ui/framework/manager.ts (+41 -9)
📝 resources/js/wysiwyg/ui/framework/modals.ts (+1 -1)
📝 resources/js/wysiwyg/ui/framework/toolbars.ts (+1 -14)
📝 resources/js/wysiwyg/ui/index.ts (+20 -58)
📝 resources/js/wysiwyg/utils/actions.ts (+1 -1)
📝 resources/sass/_editor.scss (+19 -0)
📝 resources/views/books/parts/form.blade.php (+0 -4)
📝 resources/views/chapters/parts/form.blade.php (+0 -4)

...and 6 more files

📄 Description

Switch of the comment & description editor from TinyMCE to our new custom lexical-based implementation.

Todo

Create basic toolbar
Replace in comment UI handling
- Load editor async.
Replace in shelf descriptions.
Replace in chapter descriptions.
Replace in book descriptions.
Styling in each area
Test
- Ensure tinymce script usage removed from relevant views.
- Tested each in dark-mode/FF/chromium/mobile.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5676 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 6/24/2025 **Status:** ✅ Merged **Merged:** 7/9/2025 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `lexical_comments` --- ### 📝 Commits (5) - [`c606970`](https://github.com/BookStackApp/BookStack/commit/c606970e38625d1d41c0707c4aca37249fb55a1b) Lexical: Started comment implementation - [`b80992c`](https://github.com/BookStackApp/BookStack/commit/b80992ca59a4803fe81d577add6a0611e976c83b) Comments: Switched to lexical editor - [`02a35b6`](https://github.com/BookStackApp/BookStack/commit/02a35b6db4234e9256b2c0b38e12d3eadb9b0b38) Lexical: Added new WYSIWYG to chapter/book/shelf descriptions - [`0544751`](https://github.com/BookStackApp/BookStack/commit/054475135aa6e35f7f50549c34815b190bf93b17) Lexical: Added some styling and tweaks for basic editors - [`a37d0c5`](https://github.com/BookStackApp/BookStack/commit/a37d0c57dc44c762a0b4bca9e1ca817d8e879327) Tests: Updated comment test to account for new editor usage ### 📊 Changes **26 files changed** (+388 additions, -313 deletions) <details> <summary>View changed files</summary> 📝 `app/Util/HtmlDescriptionFilter.php` (+3 -3) 📝 `resources/js/components/page-comment.ts` (+16 -18) 📝 `resources/js/components/page-comments.ts` (+15 -18) ➖ `resources/js/components/wysiwyg-input.js` (+0 -23) ➕ `resources/js/components/wysiwyg-input.ts` (+32 -0) 📝 `resources/js/wysiwyg-tinymce/config.js` (+0 -48) 📝 `resources/js/wysiwyg/index.ts` (+104 -44) 📝 `resources/js/wysiwyg/nodes.ts` (+10 -4) 📝 `resources/js/wysiwyg/ui/defaults/toolbars.ts` (+69 -44) 📝 `resources/js/wysiwyg/ui/framework/core.ts` (+16 -1) 📝 `resources/js/wysiwyg/ui/framework/decorator.ts` (+1 -1) 📝 `resources/js/wysiwyg/ui/framework/helpers/dropdowns.ts` (+11 -4) 📝 `resources/js/wysiwyg/ui/framework/manager.ts` (+41 -9) 📝 `resources/js/wysiwyg/ui/framework/modals.ts` (+1 -1) 📝 `resources/js/wysiwyg/ui/framework/toolbars.ts` (+1 -14) 📝 `resources/js/wysiwyg/ui/index.ts` (+20 -58) 📝 `resources/js/wysiwyg/utils/actions.ts` (+1 -1) 📝 `resources/sass/_editor.scss` (+19 -0) 📝 `resources/views/books/parts/form.blade.php` (+0 -4) 📝 `resources/views/chapters/parts/form.blade.php` (+0 -4) _...and 6 more files_ </details> ### 📄 Description Switch of the comment & description editor from TinyMCE to our new custom lexical-based implementation. ### Todo - [x] Create basic toolbar - [x] Replace in comment UI handling - [x] Load editor async. - [x] Replace in shelf descriptions. - [x] Replace in chapter descriptions. - [x] Replace in book descriptions. - [x] Styling in each area - [x] Test - [x] Ensure tinymce script usage removed from relevant views. - Tested each in dark-mode/FF/chromium/mobile. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:35:09 +03:00

OVERLORD closed this issue

2026-02-05 10:35:11 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6543