[PR #5626] [MERGED] Review of #5429, OIDC avatar fetching #6534

New Issue

OVERLORD · 2026-02-05T10:34:52+03:00

OVERLORD commented

2026-02-05 10:34:52 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5626
Author: @ssddanbrown
Created: 5/24/2025
Status: ✅ Merged
Merged: 5/24/2025
Merged by: @ssddanbrown

Base: development ← Head: rubentalstra-development

📝 Commits (7)

da82e70 Add optional OIDC avatar fetching from the “picture” claim
05f7f4c Merge branch 'development' of github.com:rubentalstra/BookStack into rubentalstra-development
f9dbbe5 OIDC: Updated picture fetch implementation during review
b64c9b3 OIDC: Added testing coverage for picture fetching
30bf0ce OIDC: Updated avatar fetching to run on each login
9d6bc1a Testing: Updated tests to account for recent page redirect changes
eb47e11 Avatars: Added redirect handling image fetching

📊 Changes

10 files changed (+195 additions, -19 deletions)

View changed files

📝 app/Access/Oidc/OidcService.php (+7 -1)
📝 app/Access/Oidc/OidcUserDetails.php (+16 -4)
📝 app/Config/oidc.php (+6 -0)
📝 app/Uploads/UserAvatars.php (+42 -2)
📝 app/Users/Models/User.php (+1 -0)
📝 tests/Auth/OidcTest.php (+101 -0)
📝 tests/Helpers/FileProvider.php (+8 -0)
📝 tests/Permissions/EntityPermissionsTest.php (+4 -4)
📝 tests/Permissions/RolePermissionsTest.php (+10 -8)
➕ tests/test-data/test-image.jpg (+0 -0)

📄 Description

Continuation/review of PR #5429

Doc Updates

Document added option in ldap docs
- Ensure behaviour (login where no existing avatar set) and security issues (SSR) are clearly mentioned.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5626 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 5/24/2025 **Status:** ✅ Merged **Merged:** 5/24/2025 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `rubentalstra-development` --- ### 📝 Commits (7) - [`da82e70`](https://github.com/BookStackApp/BookStack/commit/da82e70ca3cdd075f7ae148cb2f58fddb0d93627) Add optional OIDC avatar fetching from the “picture” claim - [`05f7f4c`](https://github.com/BookStackApp/BookStack/commit/05f7f4cb17470b2bdc898cf7e99781d0509c0bf8) Merge branch 'development' of github.com:rubentalstra/BookStack into rubentalstra-development - [`f9dbbe5`](https://github.com/BookStackApp/BookStack/commit/f9dbbe5d70f751d67aa41f65f257f580bcf33568) OIDC: Updated picture fetch implementation during review - [`b64c9b3`](https://github.com/BookStackApp/BookStack/commit/b64c9b31d51b5d15972c6cb37cfdca37db80d28a) OIDC: Added testing coverage for picture fetching - [`30bf0ce`](https://github.com/BookStackApp/BookStack/commit/30bf0ce632663eb508b02c2f534c817660dd5d34) OIDC: Updated avatar fetching to run on each login - [`9d6bc1a`](https://github.com/BookStackApp/BookStack/commit/9d6bc1ad4da9142766e4d3a29b5a535f93f1c33a) Testing: Updated tests to account for recent page redirect changes - [`eb47e11`](https://github.com/BookStackApp/BookStack/commit/eb47e1191665e75adcbc63876470259685b459e8) Avatars: Added redirect handling image fetching ### 📊 Changes **10 files changed** (+195 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `app/Access/Oidc/OidcService.php` (+7 -1) 📝 `app/Access/Oidc/OidcUserDetails.php` (+16 -4) 📝 `app/Config/oidc.php` (+6 -0) 📝 `app/Uploads/UserAvatars.php` (+42 -2) 📝 `app/Users/Models/User.php` (+1 -0) 📝 `tests/Auth/OidcTest.php` (+101 -0) 📝 `tests/Helpers/FileProvider.php` (+8 -0) 📝 `tests/Permissions/EntityPermissionsTest.php` (+4 -4) 📝 `tests/Permissions/RolePermissionsTest.php` (+10 -8) ➕ `tests/test-data/test-image.jpg` (+0 -0) </details> ### 📄 Description Continuation/review of PR #5429 ### Doc Updates - Document added option in ldap docs - Ensure behaviour (login where no existing avatar set) and security issues (SSR) are clearly mentioned. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:34:52 +03:00

OVERLORD closed this issue

2026-02-05 10:34:56 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6534