starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-05-04 18:08:46 +03:00
Code Issues 784 Packages Projects Releases 15 Wiki Activity

[PR #5601] [MERGED] Images: Changed how new image permissions are set #6522

New Issue
Closed
opened 2026-02-05 10:34:38 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 10:34:38 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5601
Author: @ssddanbrown
Created: 5/3/2025
Status: ✅ Merged
Merged: 5/5/2025
Merged by: @ssddanbrown

Base: development ← Head: file_permissions

📝 Commits (1)

  • 1262083 Images: Changed how new image permissions are set

📊 Changes

2 files changed (+14 additions, -7 deletions)

View changed files

📝 app/Config/filesystems.php (+0 -2)
📝 app/Uploads/ImageStorageDisk.php (+14 -5)

📄 Description

Removed default public visibility for images at the driver level, leaving only doing this as a specific action in the logic. Added try/catch around permission setting so that
permission-incompatible environments won't fatally fail, but instead log a warning.

Tested via a google cloud storage bucket FUSE mount, mounted under another user but with open 777 permissions.

Related to #5269

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5601 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 5/3/2025 **Status:** ✅ Merged **Merged:** 5/5/2025 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `file_permissions` --- ### 📝 Commits (1) - [`1262083`](https://github.com/BookStackApp/BookStack/commit/1262083fcf48f522394d3a0cd7001be3e66eec53) Images: Changed how new image permissions are set ### 📊 Changes **2 files changed** (+14 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `app/Config/filesystems.php` (+0 -2) 📝 `app/Uploads/ImageStorageDisk.php` (+14 -5) </details> ### 📄 Description Removed default public visibility for images at the driver level, leaving only doing this as a specific action in the logic. Added try/catch around permission setting so that permission-incompatible environments won't fatally fail, but instead log a warning. Tested via a google cloud storage bucket FUSE mount, mounted under another user but with open 777 permissions. Related to #5269 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:34:38 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6522
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?