[PR #5558] [MERGED] Lexical Fixes: Round 3 #6518

New Issue

OVERLORD · 2026-02-05T10:34:29+03:00

OVERLORD commented

2026-02-05 10:34:29 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5558
Author: @ssddanbrown
Created: 3/27/2025
Status: ✅ Merged
Merged: 4/2/2025
Merged by: @ssddanbrown

Base: development ← Head: lexical_round3

📝 Commits (5)

5c6671b Lexical: Fixed issues with content not saving
c03e441 Lexical: Fixed task list parsing
62c8eb3 Lexical: Made list selections & intendting more reliable
9bfcadd Lexical: Improved navigation around images/media
bb44334 Lexical: Added tests to cover recent changes

📊 Changes

11 files changed (+329 additions, -180 deletions)

View changed files

📝 resources/js/components/page-editor.js (+1 -1)
📝 resources/js/components/wysiwyg-editor.js (+4 -1)
📝 resources/js/wysiwyg/lexical/core/__tests__/utils/index.ts (+4 -0)
📝 resources/js/wysiwyg/lexical/list/LexicalListNode.ts (+13 -1)
📝 resources/js/wysiwyg/lexical/list/__tests__/unit/LexicalListNode.test.ts (+174 -162)
📝 resources/js/wysiwyg/lexical/rich-text/LexicalImageNode.ts (+1 -1)
📝 resources/js/wysiwyg/services/__tests__/keyboard-handling.test.ts (+32 -1)
📝 resources/js/wysiwyg/services/keyboard-handling.ts (+37 -3)
📝 resources/js/wysiwyg/utils/lists.ts (+37 -10)
📝 resources/js/wysiwyg/utils/nodes.ts (+24 -0)
📝 resources/sass/_editor.scss (+2 -0)

📄 Description

As per #5245.

Fixed issues with content not saving on short-cut usage.
Fixed task list handling from prior editor formats.
Improved reliability and fixed issues with list nesting operations & selection.
Improved keyboard navigation to areas around images.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5558 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 3/27/2025 **Status:** ✅ Merged **Merged:** 4/2/2025 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `lexical_round3` --- ### 📝 Commits (5) - [`5c6671b`](https://github.com/BookStackApp/BookStack/commit/5c6671b3bf5b582c2ed0e120bb8afb5f296a63e9) Lexical: Fixed issues with content not saving - [`c03e441`](https://github.com/BookStackApp/BookStack/commit/c03e44124a3312d6832f71103bda76ab66646a54) Lexical: Fixed task list parsing - [`62c8eb3`](https://github.com/BookStackApp/BookStack/commit/62c8eb335785e41c730569ec34df7137f2f325f1) Lexical: Made list selections & intendting more reliable - [`9bfcadd`](https://github.com/BookStackApp/BookStack/commit/9bfcadd95f4c3917ff4aa4fd4b10bfa7ce4c6c09) Lexical: Improved navigation around images/media - [`bb44334`](https://github.com/BookStackApp/BookStack/commit/bb44334224d6eee53b229e1f59d63b4f1ef45e68) Lexical: Added tests to cover recent changes ### 📊 Changes **11 files changed** (+329 additions, -180 deletions) <details> <summary>View changed files</summary> 📝 `resources/js/components/page-editor.js` (+1 -1) 📝 `resources/js/components/wysiwyg-editor.js` (+4 -1) 📝 `resources/js/wysiwyg/lexical/core/__tests__/utils/index.ts` (+4 -0) 📝 `resources/js/wysiwyg/lexical/list/LexicalListNode.ts` (+13 -1) 📝 `resources/js/wysiwyg/lexical/list/__tests__/unit/LexicalListNode.test.ts` (+174 -162) 📝 `resources/js/wysiwyg/lexical/rich-text/LexicalImageNode.ts` (+1 -1) 📝 `resources/js/wysiwyg/services/__tests__/keyboard-handling.test.ts` (+32 -1) 📝 `resources/js/wysiwyg/services/keyboard-handling.ts` (+37 -3) 📝 `resources/js/wysiwyg/utils/lists.ts` (+37 -10) 📝 `resources/js/wysiwyg/utils/nodes.ts` (+24 -0) 📝 `resources/sass/_editor.scss` (+2 -0) </details> ### 📄 Description As per #5245. - Fixed issues with content not saving on short-cut usage. - Fixed task list handling from prior editor formats. - Improved reliability and fixed issues with list nesting operations & selection. - Improved keyboard navigation to areas around images. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:34:29 +03:00

OVERLORD closed this issue

2026-02-05 10:34:35 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6518