[PR #5491] [MERGED] Addressing PHP 8.4 Deprecations #6506

Closed
opened 2026-02-05 10:34:07 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5491
Author: @ssddanbrown
Created: 2/17/2025
Status: Merged
Merged: 2/23/2025
Merged by: @ssddanbrown

Base: developmentHead: deprecations


📝 Commits (2)

  • 5508c17 PHP: Addressed 8.4 deprecations within app itself
  • 5050719 PHP: Updated DOMPDF version

📊 Changes

17 files changed (+53 additions, -40 deletions)

View changed files

📝 app/Access/Ldap.php (+4 -4)
📝 app/Access/SocialDriverManager.php (+1 -1)
📝 app/App/helpers.php (+3 -3)
📝 app/Config/exports.php (+1 -0)
📝 app/Entities/Controllers/BookController.php (+2 -2)
📝 app/Entities/Controllers/PageController.php (+2 -2)
📝 app/Entities/Queries/QueryPopular.php (+2 -2)
📝 app/Entities/Repos/RevisionRepo.php (+1 -1)
📝 app/Theming/ThemeService.php (+1 -1)
📝 app/Uploads/ImageRepo.php (+13 -7)
📝 app/Uploads/ImageService.php (+2 -2)
📝 app/Users/Controllers/UserApiController.php (+2 -2)
📝 app/Util/SsrUrlValidator.php (+6 -1)
📝 composer.json (+1 -1)
📝 composer.lock (+6 -6)
📝 dev/docs/logical-theme-system.md (+1 -0)
📝 tests/Entity/PageEditorTest.php (+5 -5)

📄 Description

For #5358


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5491 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 2/17/2025 **Status:** ✅ Merged **Merged:** 2/23/2025 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `deprecations` --- ### 📝 Commits (2) - [`5508c17`](https://github.com/BookStackApp/BookStack/commit/5508c171db9ab34feb62694d912d4521cfa7b2ef) PHP: Addressed 8.4 deprecations within app itself - [`5050719`](https://github.com/BookStackApp/BookStack/commit/5050719ea3933efcaaf3f69e51b25fcca0383f5b) PHP: Updated DOMPDF version ### 📊 Changes **17 files changed** (+53 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `app/Access/Ldap.php` (+4 -4) 📝 `app/Access/SocialDriverManager.php` (+1 -1) 📝 `app/App/helpers.php` (+3 -3) 📝 `app/Config/exports.php` (+1 -0) 📝 `app/Entities/Controllers/BookController.php` (+2 -2) 📝 `app/Entities/Controllers/PageController.php` (+2 -2) 📝 `app/Entities/Queries/QueryPopular.php` (+2 -2) 📝 `app/Entities/Repos/RevisionRepo.php` (+1 -1) 📝 `app/Theming/ThemeService.php` (+1 -1) 📝 `app/Uploads/ImageRepo.php` (+13 -7) 📝 `app/Uploads/ImageService.php` (+2 -2) 📝 `app/Users/Controllers/UserApiController.php` (+2 -2) 📝 `app/Util/SsrUrlValidator.php` (+6 -1) 📝 `composer.json` (+1 -1) 📝 `composer.lock` (+6 -6) 📝 `dev/docs/logical-theme-system.md` (+1 -0) 📝 `tests/Entity/PageEditorTest.php` (+5 -5) </details> ### 📄 Description For #5358 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:34:07 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6506