[PR #5415] [MERGED] Further Lexical Fixes #6494

New Issue

OVERLORD · 2026-02-05T10:33:46+03:00

OVERLORD commented

2026-02-05 10:33:46 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5415
Author: @ssddanbrown
Created: 1/15/2025
Status: ✅ Merged
Merged: 2/16/2025
Merged by: @ssddanbrown

Base: development ← Head: more_lexical_fixes

📝 Commits (9)

0d1a237 Lexical: Fixed auto-link issue
7f5fd16 Lexical: Added some general test guidance
c091f67 Lexical: Added color format custom color select
04cca77 Lexical: Added color picker/indicator to form fields
8a66365 Lexical: Added support for table caption nodes
958b537 Lexical: Linked table form to have caption toggle option
d89a2fd Lexical: Added media src conversions
7e03a97 Lexical: Ran a deeper check on translation use
2b74642 Lexical: Fixed code in lists, removed extra old alignment code

📊 Changes

35 files changed (+569 additions, -237 deletions)

View changed files

📝 lang/en/editor.php (+2 -0)
➕ resources/icons/editor/color-display.svg (+10 -0)
➕ resources/icons/editor/color-select.svg (+1 -0)
📝 resources/js/wysiwyg/lexical/core/LexicalCommands.ts (+0 -3)
📝 resources/js/wysiwyg/lexical/core/LexicalConstants.ts (+0 -22)
📝 resources/js/wysiwyg/lexical/core/LexicalNode.ts (+16 -0)
📝 resources/js/wysiwyg/lexical/core/LexicalReconciler.ts (+13 -8)
📝 resources/js/wysiwyg/lexical/core/__tests__/utils/index.ts (+27 -2)
📝 resources/js/wysiwyg/lexical/core/index.ts (+0 -4)
📝 resources/js/wysiwyg/lexical/core/nodes/LexicalElementNode.ts (+0 -9)
📝 resources/js/wysiwyg/lexical/core/nodes/LexicalTextNode.ts (+5 -0)
📝 resources/js/wysiwyg/lexical/core/shared/invariant.ts (+5 -5)
📝 resources/js/wysiwyg/lexical/html/index.ts (+1 -3)
📝 resources/js/wysiwyg/lexical/rich-text/LexicalCodeBlockNode.ts (+8 -1)
📝 resources/js/wysiwyg/lexical/rich-text/LexicalMediaNode.ts (+48 -1)
📝 resources/js/wysiwyg/lexical/rich-text/index.ts (+0 -21)
➕ resources/js/wysiwyg/lexical/table/LexicalCaptionNode.ts (+92 -0)
📝 resources/js/wysiwyg/lexical/table/LexicalTableNode.ts (+2 -0)
📝 resources/js/wysiwyg/nodes.ts (+2 -0)
📝 resources/js/wysiwyg/services/__tests__/auto-links.test.ts (+53 -68)

...and 15 more files

📄 Description

Related to #5245

Adds additional test helpers and documentation.
Fixed issues with auto-url on space/enter, when at the end of a line.
Adds custom color select/management to color picker controls.
Adds color pickers to relevant form fields.
Adds table caption support.
Adds src conversions for YouTube urls via media insert.
Fixed error importing code blocks in some cases.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5415 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 1/15/2025 **Status:** ✅ Merged **Merged:** 2/16/2025 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `more_lexical_fixes` --- ### 📝 Commits (9) - [`0d1a237`](https://github.com/BookStackApp/BookStack/commit/0d1a237f8150ed103349ce0485472fb247c3251e) Lexical: Fixed auto-link issue - [`7f5fd16`](https://github.com/BookStackApp/BookStack/commit/7f5fd16dc601039a0ff14749c98d8ea35902ec4c) Lexical: Added some general test guidance - [`c091f67`](https://github.com/BookStackApp/BookStack/commit/c091f67db334024bd6b4c65d1833b2c60e3e0a45) Lexical: Added color format custom color select - [`04cca77`](https://github.com/BookStackApp/BookStack/commit/04cca77ae6d84e0f7c3aceef6c0bc3682258c5c9) Lexical: Added color picker/indicator to form fields - [`8a66365`](https://github.com/BookStackApp/BookStack/commit/8a66365d48f8c1b4a8926dd632fe0fb1868cdc43) Lexical: Added support for table caption nodes - [`958b537`](https://github.com/BookStackApp/BookStack/commit/958b537a49c442699ec1834d437ce55c8db6394a) Lexical: Linked table form to have caption toggle option - [`d89a2fd`](https://github.com/BookStackApp/BookStack/commit/d89a2fdb150880bf98292bff3e16083179709ffb) Lexical: Added media src conversions - [`7e03a97`](https://github.com/BookStackApp/BookStack/commit/7e03a973d88999f1e22b601d0b2f6c947d0bd5fc) Lexical: Ran a deeper check on translation use - [`2b74642`](https://github.com/BookStackApp/BookStack/commit/2b746425c9c3d08a89649362396eaa75a1ccf626) Lexical: Fixed code in lists, removed extra old alignment code ### 📊 Changes **35 files changed** (+569 additions, -237 deletions) <details> <summary>View changed files</summary> 📝 `lang/en/editor.php` (+2 -0) ➕ `resources/icons/editor/color-display.svg` (+10 -0) ➕ `resources/icons/editor/color-select.svg` (+1 -0) 📝 `resources/js/wysiwyg/lexical/core/LexicalCommands.ts` (+0 -3) 📝 `resources/js/wysiwyg/lexical/core/LexicalConstants.ts` (+0 -22) 📝 `resources/js/wysiwyg/lexical/core/LexicalNode.ts` (+16 -0) 📝 `resources/js/wysiwyg/lexical/core/LexicalReconciler.ts` (+13 -8) 📝 `resources/js/wysiwyg/lexical/core/__tests__/utils/index.ts` (+27 -2) 📝 `resources/js/wysiwyg/lexical/core/index.ts` (+0 -4) 📝 `resources/js/wysiwyg/lexical/core/nodes/LexicalElementNode.ts` (+0 -9) 📝 `resources/js/wysiwyg/lexical/core/nodes/LexicalTextNode.ts` (+5 -0) 📝 `resources/js/wysiwyg/lexical/core/shared/invariant.ts` (+5 -5) 📝 `resources/js/wysiwyg/lexical/html/index.ts` (+1 -3) 📝 `resources/js/wysiwyg/lexical/rich-text/LexicalCodeBlockNode.ts` (+8 -1) 📝 `resources/js/wysiwyg/lexical/rich-text/LexicalMediaNode.ts` (+48 -1) 📝 `resources/js/wysiwyg/lexical/rich-text/index.ts` (+0 -21) ➕ `resources/js/wysiwyg/lexical/table/LexicalCaptionNode.ts` (+92 -0) 📝 `resources/js/wysiwyg/lexical/table/LexicalTableNode.ts` (+2 -0) 📝 `resources/js/wysiwyg/nodes.ts` (+2 -0) 📝 `resources/js/wysiwyg/services/__tests__/auto-links.test.ts` (+53 -68) _...and 15 more files_ </details> ### 📄 Description Related to #5245 --- - Adds additional test helpers and documentation. - Fixed issues with auto-url on space/enter, when at the end of a line. - Adds custom color select/management to color picker controls. - Adds color pickers to relevant form fields. - Adds table caption support. - Adds src conversions for YouTube urls via media insert. - Fixed error importing code blocks in some cases. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:33:46 +03:00

OVERLORD closed this issue

2026-02-05 10:33:48 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6494