[PR #5379] [MERGED] Export limits and cleanup #6486

New Issue

OVERLORD · 2026-02-05T10:33:31+03:00

OVERLORD commented

2026-02-05 10:33:31 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5379
Author: @ssddanbrown
Created: 12/31/2024
Status: ✅ Merged
Merged: 1/5/2025
Merged by: @ssddanbrown

Base: development ← Head: better_cleanup

📝 Commits (3)

6d7ff59 ZIP Exports: Improved temp file tracking & clean-up
7e31725 Exports: Improved PDF command temp file cleanup
1ff2826 Exports: Added rate limits for UI exports

📊 Changes

9 files changed (+130 additions, -10 deletions)

View changed files

📝 app/App/Providers/RouteServiceProvider.php (+7 -0)
📝 app/Exports/Controllers/BookExportController.php (+2 -1)
📝 app/Exports/Controllers/ChapterExportController.php (+2 -1)
📝 app/Exports/Controllers/PageExportController.php (+2 -1)
📝 app/Exports/PdfGenerator.php (+11 -1)
📝 app/Exports/ZipExports/ZipExportBuilder.php (+21 -4)
📝 app/Http/DownloadResponseFactory.php (+27 -1)
📝 tests/Exports/PdfExportTest.php (+17 -1)
📝 tests/Exports/ZipExportTest.php (+41 -0)

📄 Description

Related to #5374

Todo

Add general app-side export rate limits
Check over PDF export

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5379 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 12/31/2024 **Status:** ✅ Merged **Merged:** 1/5/2025 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `better_cleanup` --- ### 📝 Commits (3) - [`6d7ff59`](https://github.com/BookStackApp/BookStack/commit/6d7ff59a89e572f7ce25057a858e5223740b8549) ZIP Exports: Improved temp file tracking & clean-up - [`7e31725`](https://github.com/BookStackApp/BookStack/commit/7e31725d48f502a3c51d0382c874affa13fdf8ff) Exports: Improved PDF command temp file cleanup - [`1ff2826`](https://github.com/BookStackApp/BookStack/commit/1ff28266787b0f160697cdc74dfb05907611fcc6) Exports: Added rate limits for UI exports ### 📊 Changes **9 files changed** (+130 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `app/App/Providers/RouteServiceProvider.php` (+7 -0) 📝 `app/Exports/Controllers/BookExportController.php` (+2 -1) 📝 `app/Exports/Controllers/ChapterExportController.php` (+2 -1) 📝 `app/Exports/Controllers/PageExportController.php` (+2 -1) 📝 `app/Exports/PdfGenerator.php` (+11 -1) 📝 `app/Exports/ZipExports/ZipExportBuilder.php` (+21 -4) 📝 `app/Http/DownloadResponseFactory.php` (+27 -1) 📝 `tests/Exports/PdfExportTest.php` (+17 -1) 📝 `tests/Exports/ZipExportTest.php` (+41 -0) </details> ### 📄 Description Related to #5374 ### Todo - [x] Add general app-side export rate limits - [x] Check over PDF export --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:33:31 +03:00

OVERLORD closed this issue

2026-02-05 10:33:32 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6486