[PR #5337] [MERGED] Improve Oidc userinfo response Content-Type matching #6472

New Issue

OVERLORD · 2026-02-05T10:33:15+03:00

OVERLORD commented

2026-02-05 10:33:15 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5337
Author: @wesbiggs
Created: 11/26/2024
Status: ✅ Merged
Merged: 11/28/2024
Merged by: @ssddanbrown

Base: development ← Head: oidc-content-type-issue

📝 Commits (1)

17f7afe Updates the OIDC userinfo endpoint request to allow for a Content-Type response header with optional parameters, like application/json; charset=utf-8. This was causing an issue when integrating with node-oidc-provider.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 app/Access/Oidc/OidcUserinfoResponse.php (+1 -1)

📄 Description

Updates the OIDC userinfo endpoint request to allow for a Content-Type response header with optional parameters, like application/json; charset=utf-8. This was causing an issue (failure to find a valid subject claim) when integrating with node-oidc-provider.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5337 **Author:** [@wesbiggs](https://github.com/wesbiggs) **Created:** 11/26/2024 **Status:** ✅ Merged **Merged:** 11/28/2024 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `oidc-content-type-issue` --- ### 📝 Commits (1) - [`17f7afe`](https://github.com/BookStackApp/BookStack/commit/17f7afe12d617358ba59489fb544f339839e7370) Updates the OIDC userinfo endpoint request to allow for a `Content-Type` response header with optional parameters, like `application/json; charset=utf-8`. This was causing an issue when integrating with [node-oidc-provider](https://github.com/panva/node-oidc-provider). ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Access/Oidc/OidcUserinfoResponse.php` (+1 -1) </details> ### 📄 Description Updates the OIDC userinfo endpoint request to allow for a `Content-Type` response header with optional parameters, like `application/json; charset=utf-8`. This was causing an issue (failure to find a valid subject claim) when integrating with [node-oidc-provider](https://github.com/panva/node-oidc-provider). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:33:15 +03:00

OVERLORD closed this issue

2026-02-05 10:33:17 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6472