[PR #5295] [MERGED] Added support for concatenating multiple LDAP attributes in displayName #6471

New Issue

OVERLORD · 2026-02-05T10:33:09+03:00

OVERLORD commented

2026-02-05 10:33:09 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5295
Author: @MatthieuLeboeuf
Created: 10/29/2024
Status: ✅ Merged
Merged: 12/1/2024
Merged by: @ssddanbrown

Base: development ← Head: fix-ldap-display-name

📝 Commits (2)

72d9ffd Added support for concatenating multiple LDAP attributes in displayName
87242ce Adapt tests with displayName array

📊 Changes

3 files changed (+30 additions, -8 deletions)

View changed files

📝 app/Access/LdapService.php (+26 -4)
📝 app/Config/services.php (+1 -1)
📝 tests/Auth/LdapTest.php (+3 -3)

📄 Description

Hello

To resolve #1684 and the next of #5288

I've made the requested changes, but I can't seem to fix the test error. Do you have any ideas ?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5295 **Author:** [@MatthieuLeboeuf](https://github.com/MatthieuLeboeuf) **Created:** 10/29/2024 **Status:** ✅ Merged **Merged:** 12/1/2024 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `fix-ldap-display-name` --- ### 📝 Commits (2) - [`72d9ffd`](https://github.com/BookStackApp/BookStack/commit/72d9ffd8b4a0680a858446c5f753db4f989f3989) Added support for concatenating multiple LDAP attributes in displayName - [`87242ce`](https://github.com/BookStackApp/BookStack/commit/87242ce6cb462bc933e63d80e514ae5096ee2b67) Adapt tests with displayName array ### 📊 Changes **3 files changed** (+30 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `app/Access/LdapService.php` (+26 -4) 📝 `app/Config/services.php` (+1 -1) 📝 `tests/Auth/LdapTest.php` (+3 -3) </details> ### 📄 Description Hello To resolve #1684 and the next of #5288 I've made the requested changes, but I can't seem to fix the test error. Do you have any ideas ? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:33:09 +03:00

OVERLORD closed this issue

2026-02-05 10:33:11 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6471