[PR #5313] [MERGED] ExportFormatter: Add missing book description and remove extra newlines in markdown export #6468

Closed
opened 2026-02-05 10:33:07 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5313
Author: @czemu
Created: 11/10/2024
Status: Merged
Merged: 12/2/2024
Merged by: @ssddanbrown

Base: developmentHead: fix/markdown-export


📝 Commits (1)

  • f12946d ExportFormatter: Add book description and check for empty book and chapter descriptions in markdown export

📊 Changes

1 file changed (+10 additions, -1 deletions)

View changed files

📝 app/Entities/Tools/ExportFormatter.php (+10 -1)

📄 Description

Hi,

This pull request includes two updates to the app/Entities/Tools/ExportFormatter.php file regarding the markdown export:

  1. Added the missing book description in the bookToMarkdown() method.
  2. Added a check for an empty chapter description, preventing unwanted extra lines (\n\n) between the chapter name and the page content when the description is empty.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5313 **Author:** [@czemu](https://github.com/czemu) **Created:** 11/10/2024 **Status:** ✅ Merged **Merged:** 12/2/2024 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `fix/markdown-export` --- ### 📝 Commits (1) - [`f12946d`](https://github.com/BookStackApp/BookStack/commit/f12946d581fe66d5269f992db6573bb892286303) ExportFormatter: Add book description and check for empty book and chapter descriptions in markdown export ### 📊 Changes **1 file changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Entities/Tools/ExportFormatter.php` (+10 -1) </details> ### 📄 Description Hi, This pull request includes two updates to the `app/Entities/Tools/ExportFormatter.php` file regarding the markdown export: 1. Added the missing book description in the `bookToMarkdown()` method. 2. Added a check for an empty chapter description, preventing unwanted extra lines (`\n\n`) between the chapter name and the page content when the description is empty. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:33:08 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6468