[PR #5288] [CLOSED] Add firstName and lastName variables for LDAP #6465

Closed
opened 2026-02-05 10:33:00 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5288
Author: @MatthieuLeboeuf
Created: 10/25/2024
Status: Closed

Base: developmentHead: fix-ldap-display-name


📝 Commits (1)

  • 0346c43 Add support of first_name and last_name ldap variables to override display_name

📊 Changes

2 files changed (+15 additions, -2 deletions)

View changed files

📝 app/Access/LdapService.php (+13 -2)
📝 app/Config/services.php (+2 -0)

📄 Description

Hello !

To resolve #1684

I added two fields, LDAP_FIRST_NAME_ATTRIBUTE and LDAP_LAST_NAME_ATTRIBUTE, which, if both are filled, allow replacing LDAP_DISPLAY_NAME_ATTRIBUTE.

I did not set default values to avoid breaking existing installations.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5288 **Author:** [@MatthieuLeboeuf](https://github.com/MatthieuLeboeuf) **Created:** 10/25/2024 **Status:** ❌ Closed **Base:** `development` ← **Head:** `fix-ldap-display-name` --- ### 📝 Commits (1) - [`0346c43`](https://github.com/BookStackApp/BookStack/commit/0346c438491709a5720464175622a174104b0336) Add support of first_name and last_name ldap variables to override display_name ### 📊 Changes **2 files changed** (+15 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/Access/LdapService.php` (+13 -2) 📝 `app/Config/services.php` (+2 -0) </details> ### 📄 Description Hello ! To resolve #1684 I added two fields, LDAP_FIRST_NAME_ATTRIBUTE and LDAP_LAST_NAME_ATTRIBUTE, which, if both are filled, allow replacing LDAP_DISPLAY_NAME_ATTRIBUTE. I did not set default values to avoid breaking existing installations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:33:00 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6465