[PR #5255] [MERGED] Validate settings categories by checking for existing views #6461

New Issue

OVERLORD · 2026-02-05T10:32:52+03:00

OVERLORD commented

2026-02-05 10:32:52 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5255
Author: @LachTrip
Created: 10/11/2024
Status: ✅ Merged
Merged: 10/11/2024
Merged by: @ssddanbrown

Base: development ← Head: development

📝 Commits (2)

b9b5003 Refactor SettingController to validate categies by existing view files
a3d0f74 Move settings category layouts into their own view folder

📊 Changes

4 files changed (+3 additions, -5 deletions)

View changed files

📝 app/Settings/SettingController.php (+3 -5)
📝 resources/views/settings/categories/customization.blade.php (+0 -0)
📝 resources/views/settings/categories/features.blade.php (+0 -0)
📝 resources/views/settings/categories/registration.blade.php (+0 -0)

📄 Description

Removes fixed categories array and validates by checking the relevant view exists. Allows for custom settings categories to be added via theme system. #5251

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5255 **Author:** [@LachTrip](https://github.com/LachTrip) **Created:** 10/11/2024 **Status:** ✅ Merged **Merged:** 10/11/2024 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `development` --- ### 📝 Commits (2) - [`b9b5003`](https://github.com/BookStackApp/BookStack/commit/b9b500323947f30ce8e7b2e19287ddefc27c4edb) Refactor SettingController to validate categies by existing view files - [`a3d0f74`](https://github.com/BookStackApp/BookStack/commit/a3d0f7478f307bb979c9cb99953ef0856b9ba7ce) Move settings category layouts into their own view folder ### 📊 Changes **4 files changed** (+3 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/Settings/SettingController.php` (+3 -5) 📝 `resources/views/settings/categories/customization.blade.php` (+0 -0) 📝 `resources/views/settings/categories/features.blade.php` (+0 -0) 📝 `resources/views/settings/categories/registration.blade.php` (+0 -0) </details> ### 📄 Description Removes fixed categories array and validates by checking the relevant view exists. Allows for custom settings categories to be added via theme system. #5251 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:32:52 +03:00

OVERLORD closed this issue

2026-02-05 10:32:54 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6461