[PR #5177] [CLOSED] Add support for OIDC picture #6453

New Issue

OVERLORD · 2026-02-05T10:32:41+03:00

OVERLORD commented

2026-02-05 10:32:41 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5177
Author: @jasonpincin
Created: 8/24/2024
Status: ❌ Closed

Base: development ← Head: oidc-picture

📝 Commits (1)

67e435b Add support for OIDC picture

📊 Changes

5 files changed (+16 additions, -13 deletions)

View changed files

📝 app/Access/Oidc/OidcService.php (+2 -1)
📝 app/Access/Oidc/OidcUserDetails.php (+2 -0)
📝 app/Access/RegistrationService.php (+4 -4)
📝 app/Uploads/UserAvatars.php (+4 -4)
📝 app/Users/UserRepo.php (+4 -4)

📄 Description

This is a naive first attempt at adding support for OIDC pictures. It works (for me) which is about all I can say about it.

Tossing it up there in case it's useful, or for feedback. Happy to develop the PR further if there's broader interest in the feature. If I were to develop it further, I'd be curious if there's thoughts on better ways of plumbing the picture path through, and if there's any mechanism for refreshing the user's avatar that would need to be updated. It wasn't immediately evident to me that this existed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5177 **Author:** [@jasonpincin](https://github.com/jasonpincin) **Created:** 8/24/2024 **Status:** ❌ Closed **Base:** `development` ← **Head:** `oidc-picture` --- ### 📝 Commits (1) - [`67e435b`](https://github.com/BookStackApp/BookStack/commit/67e435b2fe9aa885496585443c04964eeff6a0f2) Add support for OIDC picture ### 📊 Changes **5 files changed** (+16 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `app/Access/Oidc/OidcService.php` (+2 -1) 📝 `app/Access/Oidc/OidcUserDetails.php` (+2 -0) 📝 `app/Access/RegistrationService.php` (+4 -4) 📝 `app/Uploads/UserAvatars.php` (+4 -4) 📝 `app/Users/UserRepo.php` (+4 -4) </details> ### 📄 Description This is a naive first attempt at adding support for OIDC pictures. It works (for me) which is about all I can say about it. Tossing it up there in case it's useful, or for feedback. Happy to develop the PR further if there's broader interest in the feature. If I were to develop it further, I'd be curious if there's thoughts on better ways of plumbing the picture path through, and if there's any mechanism for refreshing the user's avatar that would need to be updated. It wasn't immediately evident to me that this existed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:32:41 +03:00

OVERLORD closed this issue

2026-02-05 10:32:44 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6453