starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-02-09 03:09:38 +03:00
Code Issues 784 Packages Projects Releases 10 Wiki Activity

[PR #5132] [CLOSED] Add popularity sorting options for books #6451

New Issue
Closed
opened 2026-02-05 10:32:35 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 10:32:35 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5132
Author: @fuszti
Created: 7/19/2024
Status: ❌ Closed

Base: development ← Head: issue_1712

📝 Commits (3)

  • d6a4e44 Add popularity sorting options for books
  • af02899 Delete debug lines from BookSortingTest
  • 5d17e99 Fix too long function in BookController

📊 Changes

3 files changed (+161 additions, -14 deletions)

View changed files

📝 app/Entities/Controllers/BookController.php (+30 -14)
📝 lang/en/common.php (+1 -0)
➕ tests/Entity/BookSortingTest.php (+130 -0)

📄 Description

Now the user can sort the /books by the view_count. It is the #1712 feature request.

Unit tests are added too.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5132 **Author:** [@fuszti](https://github.com/fuszti) **Created:** 7/19/2024 **Status:** ❌ Closed **Base:** `development` ← **Head:** `issue_1712` --- ### 📝 Commits (3) - [`d6a4e44`](https://github.com/BookStackApp/BookStack/commit/d6a4e44870fbca47b73bf08cab687ca1616fdf0e) Add popularity sorting options for books - [`af02899`](https://github.com/BookStackApp/BookStack/commit/af02899f08cbf856a75e8fbc0652c8a1dad7b66b) Delete debug lines from BookSortingTest - [`5d17e99`](https://github.com/BookStackApp/BookStack/commit/5d17e991b64a615b281395bcc165e01d23b339c7) Fix too long function in BookController ### 📊 Changes **3 files changed** (+161 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `app/Entities/Controllers/BookController.php` (+30 -14) 📝 `lang/en/common.php` (+1 -0) ➕ `tests/Entity/BookSortingTest.php` (+130 -0) </details> ### 📄 Description Now the user can sort the /books by the view_count. It is the #1712 feature request. Unit tests are added too. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:32:35 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6451
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?