starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-05-04 18:08:46 +03:00
Code Issues 784 Packages Projects Releases 15 Wiki Activity

[PR #5096] [MERGED] Wraps file extension comparison components in strtolower() #6449

New Issue
Closed
opened 2026-02-05 10:32:33 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 10:32:33 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5096
Author: @DanielGordonIT
Created: 7/3/2024
Status: ✅ Merged
Merged: 7/14/2024
Merged by: @ssddanbrown

Base: development ← Head: normalize-file-extensions

📝 Commits (3)

  • 9b0ef85 Wraps file extension comparison components in strtolower()
  • 25f92ce Add test to verify different case on extensions works
  • ca31096 Actually add the test this time

📊 Changes

2 files changed (+28 additions, -1 deletions)

View changed files

📝 app/Uploads/ImageRepo.php (+1 -1)
📝 tests/Uploads/ImageTest.php (+27 -0)

📄 Description

Created to fix #5095
This avoids the issue where replacing file.PNG with newfile.png fails due to "PNG" not being equal to "png"

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5096 **Author:** [@DanielGordonIT](https://github.com/DanielGordonIT) **Created:** 7/3/2024 **Status:** ✅ Merged **Merged:** 7/14/2024 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `normalize-file-extensions` --- ### 📝 Commits (3) - [`9b0ef85`](https://github.com/BookStackApp/BookStack/commit/9b0ef85f77f140be8dffa2f333070f0429c15bb2) Wraps file extension comparison components in strtolower() - [`25f92ce`](https://github.com/BookStackApp/BookStack/commit/25f92ce584cf058d225cbb3560b23ca558d60c0d) Add test to verify different case on extensions works - [`ca31096`](https://github.com/BookStackApp/BookStack/commit/ca310966b2ef52460c9ad7ca79dc707ff2ed3329) Actually add the test this time ### 📊 Changes **2 files changed** (+28 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Uploads/ImageRepo.php` (+1 -1) 📝 `tests/Uploads/ImageTest.php` (+27 -0) </details> ### 📄 Description Created to fix #5095 This avoids the issue where replacing file.PNG with newfile.png fails due to "PNG" not being equal to "png" --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:32:33 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6449
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?