starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-05-04 18:08:46 +03:00
Code Issues 784 Packages Projects Releases 15 Wiki Activity

[PR #4985] [MERGED] LDAP CA TLS Cert Option, PR Review and continuation #6432

New Issue
Closed
opened 2026-02-05 10:32:10 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 10:32:10 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4985
Author: @ssddanbrown
Created: 5/3/2024
Status: ✅ Merged
Merged: 5/3/2024
Merged by: @ssddanbrown

Base: development ← Head: ldap_ca_cert_control

📝 Commits (3)

  • 06ef95d Change to allow override of CA CERT for LDAPS
  • 18269f2 Add LDAP_TLS_CACERTFILE to example env file
  • 8087123 LDAP: Review, testing and update of LDAP TLS CA cert control

📊 Changes

4 files changed (+75 additions, -1 deletions)

View changed files

📝 .env.example.complete (+1 -0)
📝 app/Access/LdapService.php (+41 -1)
📝 app/Config/services.php (+1 -0)
📝 tests/Auth/LdapTest.php (+32 -0)

📄 Description

Review of https://github.com/BookStackApp/BookStack/pull/4913
Added testing to cover option.
Updated option so it can be used for a CA directory, or a CA file.
Updated option name to be somewhat abstracted from original underling
PHP option.

Tested against Jumpcloud.
Testing took hours due to instability which was due to these settings
sticking and being unstable on change until php process restart.
Also due to little documentation for these options.
X_TLS_CACERTDIR option needs cert files to be named via specific hashes
which can be achieved via c_rehash utility.

This also adds detail on STARTTLS failure, which took a long time to
discover due to little detail out there for deeper PHP LDAP debugging.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4985 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 5/3/2024 **Status:** ✅ Merged **Merged:** 5/3/2024 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `ldap_ca_cert_control` --- ### 📝 Commits (3) - [`06ef95d`](https://github.com/BookStackApp/BookStack/commit/06ef95dc5fc4635379698cf73bd36d4b370aab69) Change to allow override of CA CERT for LDAPS - [`18269f2`](https://github.com/BookStackApp/BookStack/commit/18269f2c6036b346d100fd2b82dab600f4ba362f) Add LDAP_TLS_CACERTFILE to example env file - [`8087123`](https://github.com/BookStackApp/BookStack/commit/8087123f2e1823d6584844a540bf4639c55f4fad) LDAP: Review, testing and update of LDAP TLS CA cert control ### 📊 Changes **4 files changed** (+75 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.env.example.complete` (+1 -0) 📝 `app/Access/LdapService.php` (+41 -1) 📝 `app/Config/services.php` (+1 -0) 📝 `tests/Auth/LdapTest.php` (+32 -0) </details> ### 📄 Description Review of https://github.com/BookStackApp/BookStack/pull/4913 Added testing to cover option. Updated option so it can be used for a CA directory, or a CA file. Updated option name to be somewhat abstracted from original underling PHP option. Tested against Jumpcloud. Testing took hours due to instability which was due to these settings sticking and being unstable on change until php process restart. Also due to little documentation for these options. X_TLS_CACERTDIR option needs cert files to be named via specific hashes which can be achieved via c_rehash utility. This also adds detail on STARTTLS failure, which took a long time to discover due to little detail out there for deeper PHP LDAP debugging. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:32:10 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6432
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?