[PR #4913] [MERGED] Change to allow override of CA CERT for LDAP over TLS #6428

Closed
opened 2026-02-05 10:32:00 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4913
Author: @mmoore2012
Created: 3/26/2024
Status: Merged
Merged: 5/3/2024
Merged by: @ssddanbrown

Base: developmentHead: ldaps


📝 Commits (2)

  • 06ef95d Change to allow override of CA CERT for LDAPS
  • 18269f2 Add LDAP_TLS_CACERTFILE to example env file

📊 Changes

3 files changed (+8 additions, -0 deletions)

View changed files

📝 .env.example.complete (+1 -0)
📝 app/Access/LdapService.php (+6 -0)
📝 app/Config/services.php (+1 -0)

📄 Description

I struggled to make LDAPS work with the docker app. I did get this to work by injecting the certificate into the alpine container, but this is not great as the changes will get removed on an update to the container.

The changes I propose allow using the env LDAP_TLS_CACERTFILE to set a file to use to override the CA CERT used to verify LDAPS connections. This is to make this process easier for docker use.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4913 **Author:** [@mmoore2012](https://github.com/mmoore2012) **Created:** 3/26/2024 **Status:** ✅ Merged **Merged:** 5/3/2024 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `ldaps` --- ### 📝 Commits (2) - [`06ef95d`](https://github.com/BookStackApp/BookStack/commit/06ef95dc5fc4635379698cf73bd36d4b370aab69) Change to allow override of CA CERT for LDAPS - [`18269f2`](https://github.com/BookStackApp/BookStack/commit/18269f2c6036b346d100fd2b82dab600f4ba362f) Add LDAP_TLS_CACERTFILE to example env file ### 📊 Changes **3 files changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.env.example.complete` (+1 -0) 📝 `app/Access/LdapService.php` (+6 -0) 📝 `app/Config/services.php` (+1 -0) </details> ### 📄 Description I struggled to make LDAPS work with the docker app. I did get this to work by injecting the certificate into the alpine container, but this is not great as the changes will get removed on an update to the container. The changes I propose allow using the env LDAP_TLS_CACERTFILE to set a file to use to override the CA CERT used to verify LDAPS connections. This is to make this process easier for docker use. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:32:00 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6428