[PR #4907] [MERGED] Dependency Licensing Improvements #6423

New Issue

OVERLORD · 2026-02-05T10:31:53+03:00

OVERLORD commented

2026-02-05 10:31:53 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4907
Author: @ssddanbrown
Created: 3/22/2024
Status: ✅ Merged
Merged: 3/24/2024
Merged by: @ssddanbrown

Base: development ← Head: licensing_update

📝 Commits (6)

f789359 Licensing: Added script to build PHP library licensing information
55a2a6d Licensing: Added script to gen info for JS packages
ed956a4 Licensing: Updated license gen scripts to share logic
0c524c7 Licensing: Added licenses app view
a2fd809 Licensing: Added links and tests for new licenses endpoint
3345680 Licensing: Added license gen as composer command

📊 Changes

16 files changed (+3138 additions, -50 deletions)

View changed files

📝 app/App/HomeController.php (+0 -45)
➕ app/App/MetaController.php (+67 -0)
📝 composer.json (+4 -0)
📝 dev/build/esbuild.js (+4 -0)
➕ dev/licensing/gen-js-licenses (+63 -0)
➕ dev/licensing/gen-licenses-shared.php (+66 -0)
➕ dev/licensing/gen-php-licenses (+55 -0)
➕ dev/licensing/js-library-licenses.txt (+1978 -0)
➕ dev/licensing/php-library-licenses.txt (+796 -0)
📝 lang/en/settings.php (+8 -0)
📝 phpstan.neon.dist (+1 -0)
📝 readme.md (+2 -0)
➕ resources/views/help/licenses.blade.php (+61 -0)
📝 resources/views/settings/layout.blade.php (+3 -1)
📝 routes/web.php (+6 -4)
➕ tests/LicensesTest.php (+24 -0)

📄 Description

This PR aims to improve the transparency & clarity of the project dependencies and their licenses, and provides a standard & direct manner of attribution across all project dependencies.

Changes

Script listing of PHP dep licenses
Script listing of JS dep licenses
Add overall licensing info page, with other details for libraries not listed via direct deps like:
- PHP
- TinyMCE
- Material Icons
- Extract text to translations (Titles/into text, not body content).
- Add tests to cover (Page exists, Link to page)
Add neatly into app somewhere (Below version information)
Add reference to license/attribution list in built source files
Update licensing/attribution info in readme to refer to new files
Build updating of deps lists into process somehow.
- Added a composer command, which is added to release steps.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4907 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 3/22/2024 **Status:** ✅ Merged **Merged:** 3/24/2024 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `licensing_update` --- ### 📝 Commits (6) - [`f789359`](https://github.com/BookStackApp/BookStack/commit/f7893598865abe24df04c3fc60e22429818709e3) Licensing: Added script to build PHP library licensing information - [`55a2a6d`](https://github.com/BookStackApp/BookStack/commit/55a2a6db88bee277ed0cf43720428199f8d6ffc1) Licensing: Added script to gen info for JS packages - [`ed956a4`](https://github.com/BookStackApp/BookStack/commit/ed956a4cf00473f3b2ba135dbeacff65bc9602b0) Licensing: Updated license gen scripts to share logic - [`0c524c7`](https://github.com/BookStackApp/BookStack/commit/0c524c7c8f272acd4ae429f04f8678e2f8c7ba4b) Licensing: Added licenses app view - [`a2fd809`](https://github.com/BookStackApp/BookStack/commit/a2fd80954bfd0b2a98d54b9ad2c68628cd1e2b1c) Licensing: Added links and tests for new licenses endpoint - [`3345680`](https://github.com/BookStackApp/BookStack/commit/3345680f7d7e2a7b199d2a2fd607c769f4c2a672) Licensing: Added license gen as composer command ### 📊 Changes **16 files changed** (+3138 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `app/App/HomeController.php` (+0 -45) ➕ `app/App/MetaController.php` (+67 -0) 📝 `composer.json` (+4 -0) 📝 `dev/build/esbuild.js` (+4 -0) ➕ `dev/licensing/gen-js-licenses` (+63 -0) ➕ `dev/licensing/gen-licenses-shared.php` (+66 -0) ➕ `dev/licensing/gen-php-licenses` (+55 -0) ➕ `dev/licensing/js-library-licenses.txt` (+1978 -0) ➕ `dev/licensing/php-library-licenses.txt` (+796 -0) 📝 `lang/en/settings.php` (+8 -0) 📝 `phpstan.neon.dist` (+1 -0) 📝 `readme.md` (+2 -0) ➕ `resources/views/help/licenses.blade.php` (+61 -0) 📝 `resources/views/settings/layout.blade.php` (+3 -1) 📝 `routes/web.php` (+6 -4) ➕ `tests/LicensesTest.php` (+24 -0) </details> ### 📄 Description This PR aims to improve the transparency & clarity of the project dependencies and their licenses, and provides a standard & direct manner of attribution across all project dependencies. ### Changes - [x] Script listing of PHP dep licenses - [x] Script listing of JS dep licenses - [x] Add overall licensing info page, with other details for libraries not listed via direct deps like: - PHP - TinyMCE - Material Icons - [x] Extract text to translations (Titles/into text, not body content). - [x] Add tests to cover (Page exists, Link to page) - [x] Add neatly into app somewhere (Below version information) - [x] Add reference to license/attribution list in built source files - [x] Update licensing/attribution info in readme to refer to new files - [x] Build updating of deps lists into process somehow. - Added a composer command, which is added to release steps. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:31:53 +03:00

OVERLORD closed this issue

2026-02-05 10:31:54 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6423