[PR #4768] [CLOSED] try pass php-test #6403

New Issue

OVERLORD · 2026-02-05T10:31:22+03:00

OVERLORD commented

2026-02-05 10:31:22 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4768
Author: @hoyiliang
Created: 1/11/2024
Status: ❌ Closed

Base: development ← Head: hoyiliang

📝 Commits (10+)

b699b92 Fix constructor formatting in BookController
a3d15fe Fix constructor formatting and add ContextMenu
8128308 Add watch options for authenticated users
4d2be00 Add context menu component to list items
69411dd Remove unused code and context-menu component
99dc6ff Add context menu component to book list item
dcac2a3 Add context menu component to grid item view
491463c Refactor grid-item.blade.php to conditionally
6d32ab5 Refactor grid-item.blade.php to improve code
f21b468 Add div wrapper around context menu component

📊 Changes

18 files changed (+378 additions, -51 deletions)

View changed files

📝 app/Entities/Controllers/BookController.php (+5 -0)
📝 app/Entities/Controllers/ChapterController.php (+10 -0)
📝 app/Entities/Models/Chapter.php (+41 -2)
📝 app/Entities/Repos/ChapterRepo.php (+19 -1)
➕ database/migrations/2023_11_23_154913_add_image_id_to_chapters_table.php (+34 -0)
➕ resources/js/components/context-menu.js (+74 -0)
📝 resources/js/components/index.js (+1 -0)
📝 resources/sass/styles.scss (+35 -0)
➕ resources/views/books/parts/context-menu.blade.php (+79 -0)
📝 resources/views/books/parts/list-item.blade.php (+4 -1)
📝 resources/views/chapters/create.blade.php (+1 -1)
📝 resources/views/chapters/edit.blade.php (+1 -1)
📝 resources/views/chapters/parts/form.blade.php (+16 -0)
📝 resources/views/chapters/parts/list-item.blade.php (+1 -1)
📝 resources/views/chapters/show.blade.php (+33 -31)
📝 resources/views/entities/grid-item.blade.php (+14 -6)
📝 resources/views/shelves/parts/list-item.blade.php (+4 -1)
📝 tests/Entity/BookShelfTest.php (+6 -6)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4768 **Author:** [@hoyiliang](https://github.com/hoyiliang) **Created:** 1/11/2024 **Status:** ❌ Closed **Base:** `development` ← **Head:** `hoyiliang` --- ### 📝 Commits (10+) - [`b699b92`](https://github.com/BookStackApp/BookStack/commit/b699b9281b089cb075a83b0e353ad8c2fbd83355) Fix constructor formatting in BookController - [`a3d15fe`](https://github.com/BookStackApp/BookStack/commit/a3d15fe28a3e5ae555e71c2399f280f571d950ad) Fix constructor formatting and add ContextMenu - [`8128308`](https://github.com/BookStackApp/BookStack/commit/8128308f1beecbb8ddf70085875f2b6824cca716) Add watch options for authenticated users - [`4d2be00`](https://github.com/BookStackApp/BookStack/commit/4d2be0016b46a2691127cb9e2b667c9b17e717d5) Add context menu component to list items - [`69411dd`](https://github.com/BookStackApp/BookStack/commit/69411dd4632445351f19dbbb25301398f5154c89) Remove unused code and context-menu component - [`99dc6ff`](https://github.com/BookStackApp/BookStack/commit/99dc6ff67c56afeb199c9b0c13addebfd1256683) Add context menu component to book list item - [`dcac2a3`](https://github.com/BookStackApp/BookStack/commit/dcac2a33d990c55e3c3ad9d51d204c17bd274501) Add context menu component to grid item view - [`491463c`](https://github.com/BookStackApp/BookStack/commit/491463c01a2038c35ce8a1be24ce59aa9deca1ba) Refactor grid-item.blade.php to conditionally - [`6d32ab5`](https://github.com/BookStackApp/BookStack/commit/6d32ab54da66fe7db3094a5df2c88c5bbff9485a) Refactor grid-item.blade.php to improve code - [`f21b468`](https://github.com/BookStackApp/BookStack/commit/f21b468d7e1d7d45a42e6146a57b6e878fde0d64) Add div wrapper around context menu component ### 📊 Changes **18 files changed** (+378 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `app/Entities/Controllers/BookController.php` (+5 -0) 📝 `app/Entities/Controllers/ChapterController.php` (+10 -0) 📝 `app/Entities/Models/Chapter.php` (+41 -2) 📝 `app/Entities/Repos/ChapterRepo.php` (+19 -1) ➕ `database/migrations/2023_11_23_154913_add_image_id_to_chapters_table.php` (+34 -0) ➕ `resources/js/components/context-menu.js` (+74 -0) 📝 `resources/js/components/index.js` (+1 -0) 📝 `resources/sass/styles.scss` (+35 -0) ➕ `resources/views/books/parts/context-menu.blade.php` (+79 -0) 📝 `resources/views/books/parts/list-item.blade.php` (+4 -1) 📝 `resources/views/chapters/create.blade.php` (+1 -1) 📝 `resources/views/chapters/edit.blade.php` (+1 -1) 📝 `resources/views/chapters/parts/form.blade.php` (+16 -0) 📝 `resources/views/chapters/parts/list-item.blade.php` (+1 -1) 📝 `resources/views/chapters/show.blade.php` (+33 -31) 📝 `resources/views/entities/grid-item.blade.php` (+14 -6) 📝 `resources/views/shelves/parts/list-item.blade.php` (+4 -1) 📝 `tests/Entity/BookShelfTest.php` (+6 -6) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:31:22 +03:00

OVERLORD closed this issue

2026-02-05 10:31:24 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6403