[PR #4727] [MERGED] WYSWIYG: Allowed video/embed alignment controls #6399

Closed
opened 2026-02-05 10:31:16 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4727
Author: @ssddanbrown
Created: 12/16/2023
Status: Merged
Merged: 12/16/2023
Merged by: @ssddanbrown

Base: developmentHead: editor_video_alignment


📝 Commits (1)

  • 5395ca2 WYSWIYG: Allowed video/embed alignment controls

📊 Changes

4 files changed (+89 additions, -7 deletions)

View changed files

📝 resources/js/wysiwyg/config.js (+6 -3)
resources/js/wysiwyg/fixes.js (+55 -0)
📝 resources/sass/_content.scss (+4 -4)
📝 resources/sass/_tinymce.scss (+24 -0)

📄 Description

Required a lot of working around TinyMCE since it added a preview/wrapper element in the editor which complicates things. Added view new "fixes.js" file so large hacks to default TinyMCe functionality are kept in one place.

Related to #3378


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4727 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 12/16/2023 **Status:** ✅ Merged **Merged:** 12/16/2023 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `editor_video_alignment` --- ### 📝 Commits (1) - [`5395ca2`](https://github.com/BookStackApp/BookStack/commit/5395ca2f005ce111c15ec9d2fddc11c6e8814b9f) WYSWIYG: Allowed video/embed alignment controls ### 📊 Changes **4 files changed** (+89 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `resources/js/wysiwyg/config.js` (+6 -3) ➕ `resources/js/wysiwyg/fixes.js` (+55 -0) 📝 `resources/sass/_content.scss` (+4 -4) 📝 `resources/sass/_tinymce.scss` (+24 -0) </details> ### 📄 Description Required a lot of working around TinyMCE since it added a preview/wrapper element in the editor which complicates things. Added view new "fixes.js" file so large hacks to default TinyMCe functionality are kept in one place. Related to #3378 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:31:16 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6399