starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-05-04 18:08:46 +03:00
Code Issues 784 Packages Projects Releases 15 Wiki Activity

[PR #4552] [MERGED] Fixed : Comment notification settings are visible even if comments ar… #6372

New Issue
Closed
opened 2026-02-05 10:30:37 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 10:30:37 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4552
Author: @tusharnain
Created: 9/16/2023
Status: ✅ Merged
Merged: 9/18/2023
Merged by: @ssddanbrown

Base: development ← Head: development

📝 Commits (2)

  • 6a5361d Fixed : Comment notification settings are visible even if comments are disabled
  • baa957d Update UserPreferencesTest.php

📊 Changes

2 files changed (+47 additions, -14 deletions)

View changed files

📝 resources/views/users/preferences/notifications.blade.php (+16 -14)
📝 tests/User/UserPreferencesTest.php (+31 -0)

📄 Description

…e disabled

Added a UX condition to display comment notification settings, only if the user has enabled the comment notifications.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4552 **Author:** [@tusharnain](https://github.com/tusharnain) **Created:** 9/16/2023 **Status:** ✅ Merged **Merged:** 9/18/2023 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `development` --- ### 📝 Commits (2) - [`6a5361d`](https://github.com/BookStackApp/BookStack/commit/6a5361d853eccda55eadb56ec249236cd4ab164e) Fixed : Comment notification settings are visible even if comments are disabled - [`baa957d`](https://github.com/BookStackApp/BookStack/commit/baa957d98049380ff2278f222600852f70b79712) Update UserPreferencesTest.php ### 📊 Changes **2 files changed** (+47 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `resources/views/users/preferences/notifications.blade.php` (+16 -14) 📝 `tests/User/UserPreferencesTest.php` (+31 -0) </details> ### 📄 Description …e disabled Added a UX condition to display comment notification settings, only if the user has enabled the comment notifications. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:30:37 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6372
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?