[PR #4525] [MERGED] HTTP calling logic alignment #6368

New Issue

OVERLORD · 2026-02-05T10:30:29+03:00

OVERLORD commented

2026-02-05 10:30:29 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4525
Author: @ssddanbrown
Created: 9/8/2023
Status: ✅ Merged
Merged: 9/8/2023
Merged by: @ssddanbrown

Base: development ← Head: http_alignment

📝 Commits (2)

a8b5652 Started aligning app-wide outbound http calling behaviour
06490f6 Removed use of HttpFetcher

📊 Changes

14 files changed (+208 additions, -206 deletions)

View changed files

📝 app/Access/Oidc/OidcOAuthProvider.php (+3 -10)
📝 app/Access/Oidc/OidcProviderSettings.php (+1 -1)
📝 app/Access/Oidc/OidcService.php (+4 -4)
📝 app/Activity/DispatchWebhookJob.php (+16 -13)
📝 app/App/Providers/AppServiceProvider.php (+3 -9)
➕ app/Http/HttpClientHistory.php (+33 -0)
➕ app/Http/HttpRequestService.php (+70 -0)
➖ app/Uploads/HttpFetcher.php (+0 -38)
📝 app/Uploads/UserAvatars.php (+12 -10)
📝 tests/Actions/WebhookCallTest.php (+21 -29)
📝 tests/Auth/OidcTest.php (+10 -14)
📝 tests/TestCase.php (+5 -32)
📝 tests/ThemeTest.php (+5 -9)
📝 tests/Uploads/AvatarTest.php (+25 -37)

📄 Description

HTTP calling is currently a mess within the codebase, currently using three different methods:

Injected PSR-style guzzle client (OIDC)
Laravel Http facade (Webhooks)
Custom curl-based HttpFetcher (User avatars)

This PR intends to align these to a standard PSR/guzzle-based setup.

Also actioning #4397.

Todo

Replace old HTTP-Fetcher class.
Last review over changes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4525 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 9/8/2023 **Status:** ✅ Merged **Merged:** 9/8/2023 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `http_alignment` --- ### 📝 Commits (2) - [`a8b5652`](https://github.com/BookStackApp/BookStack/commit/a8b5652210bf2258847e5880d6c6866fdfdc04a3) Started aligning app-wide outbound http calling behaviour - [`06490f6`](https://github.com/BookStackApp/BookStack/commit/06490f624c3923e945bf86a2930ff85c062a0bad) Removed use of HttpFetcher ### 📊 Changes **14 files changed** (+208 additions, -206 deletions) <details> <summary>View changed files</summary> 📝 `app/Access/Oidc/OidcOAuthProvider.php` (+3 -10) 📝 `app/Access/Oidc/OidcProviderSettings.php` (+1 -1) 📝 `app/Access/Oidc/OidcService.php` (+4 -4) 📝 `app/Activity/DispatchWebhookJob.php` (+16 -13) 📝 `app/App/Providers/AppServiceProvider.php` (+3 -9) ➕ `app/Http/HttpClientHistory.php` (+33 -0) ➕ `app/Http/HttpRequestService.php` (+70 -0) ➖ `app/Uploads/HttpFetcher.php` (+0 -38) 📝 `app/Uploads/UserAvatars.php` (+12 -10) 📝 `tests/Actions/WebhookCallTest.php` (+21 -29) 📝 `tests/Auth/OidcTest.php` (+10 -14) 📝 `tests/TestCase.php` (+5 -32) 📝 `tests/ThemeTest.php` (+5 -9) 📝 `tests/Uploads/AvatarTest.php` (+25 -37) </details> ### 📄 Description HTTP calling is currently a mess within the codebase, currently using three different methods: - Injected PSR-style guzzle client (OIDC) - Laravel `Http` facade (Webhooks) - Custom curl-based `HttpFetcher` (User avatars) This PR intends to align these to a standard PSR/guzzle-based setup. Also actioning #4397. ### Todo - [x] Replace old HTTP-Fetcher class. - [x] Last review over changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:30:29 +03:00

OVERLORD closed this issue

2026-02-05 10:30:31 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6368