[PR #4318] [MERGED] Change JsonDebugException to Responsable interface #6346

Closed
opened 2026-02-05 10:29:52 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4318
Author: @devdot
Created: 6/16/2023
Status: Merged
Merged: 6/18/2023
Merged by: @ssddanbrown

Base: developmentHead: improve-json-debug-exception


📝 Commits (1)

  • 7249d94 Change JsonDebugException to Responsable interface

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 app/Exceptions/JsonDebugException.php (+3 -2)

📄 Description

In all other exceptions, when a Response is supposed to be returned, the Responsable interface is used instead of render.

It's a simple small issue that only regards code quality.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4318 **Author:** [@devdot](https://github.com/devdot) **Created:** 6/16/2023 **Status:** ✅ Merged **Merged:** 6/18/2023 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `improve-json-debug-exception` --- ### 📝 Commits (1) - [`7249d94`](https://github.com/BookStackApp/BookStack/commit/7249d947ecf829ab12686bcdb85cde1f174379e9) Change JsonDebugException to Responsable interface ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/Exceptions/JsonDebugException.php` (+3 -2) </details> ### 📄 Description In all other exceptions, when a Response is supposed to be returned, the Responsable interface is used instead of render. It's a simple small issue that only regards code quality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:29:52 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6346