[PR #4322] [MERGED] Added read-only comments listing into page editor #6344

Closed
opened 2026-02-05 10:29:49 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4322
Author: @ssddanbrown
Created: 6/16/2023
Status: Merged
Merged: 6/16/2023
Merged by: @ssddanbrown

Base: developmentHead: comments_in_editor


📝 Commits (2)

  • 9a2ef7e Comments: Added read-only listing into page editor
  • 88aae5b Comments: Fixed failing tests due to unset template variable

📊 Changes

10 files changed (+83 additions, -31 deletions)

View changed files

📝 app/Activity/Controllers/CommentController.php (+2 -1)
📝 app/Entities/Controllers/PageController.php (+4 -10)
📝 app/Entities/Tools/PageEditorData.php (+7 -10)
📝 lang/en/entities.php (+1 -0)
📝 resources/sass/_components.scss (+23 -0)
📝 resources/views/comments/comment.blade.php (+13 -8)
📝 resources/views/comments/comments.blade.php (+1 -1)
📝 resources/views/pages/parts/editor-toolbox.blade.php (+7 -1)
resources/views/pages/parts/toolbox-comments.blade.php (+15 -0)
📝 tests/Entity/CommentTest.php (+10 -0)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4322 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 6/16/2023 **Status:** ✅ Merged **Merged:** 6/16/2023 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `comments_in_editor` --- ### 📝 Commits (2) - [`9a2ef7e`](https://github.com/BookStackApp/BookStack/commit/9a2ef7ef44d75c6d68499dd554ebca31a1e68401) Comments: Added read-only listing into page editor - [`88aae5b`](https://github.com/BookStackApp/BookStack/commit/88aae5b0048823351cd2adf4537a825004cda813) Comments: Fixed failing tests due to unset template variable ### 📊 Changes **10 files changed** (+83 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `app/Activity/Controllers/CommentController.php` (+2 -1) 📝 `app/Entities/Controllers/PageController.php` (+4 -10) 📝 `app/Entities/Tools/PageEditorData.php` (+7 -10) 📝 `lang/en/entities.php` (+1 -0) 📝 `resources/sass/_components.scss` (+23 -0) 📝 `resources/views/comments/comment.blade.php` (+13 -8) 📝 `resources/views/comments/comments.blade.php` (+1 -1) 📝 `resources/views/pages/parts/editor-toolbox.blade.php` (+7 -1) ➕ `resources/views/pages/parts/toolbox-comments.blade.php` (+15 -0) 📝 `tests/Entity/CommentTest.php` (+10 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:29:49 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6344