[PR #4301] [MERGED] CSS: Updated status colors to be CSS variables, Added dark variants #6338

Closed
opened 2026-02-05 10:29:40 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4301
Author: @ssddanbrown
Created: 6/13/2023
Status: Merged
Merged: 6/13/2023
Merged by: @ssddanbrown

Base: developmentHead: css_color_variables


📝 Commits (1)

  • f7ad387 CSS: Updated status colors to be CSS variables, Added dark variants

📊 Changes

6 files changed (+47 additions, -34 deletions)

View changed files

📝 resources/sass/_blocks.scss (+13 -13)
📝 resources/sass/_codemirror.scss (+1 -1)
📝 resources/sass/_colors.scss (+6 -6)
📝 resources/sass/_components.scss (+7 -7)
📝 resources/sass/_forms.scss (+2 -2)
📝 resources/sass/_variables.scss (+18 -5)

📄 Description

Needed some level of harcoding though due to callouts using colors, which can't be css colors as DOMPDF won't understand these. Use css variables elsewhere and added new dark variants to fit a bit better.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4301 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 6/13/2023 **Status:** ✅ Merged **Merged:** 6/13/2023 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `css_color_variables` --- ### 📝 Commits (1) - [`f7ad387`](https://github.com/BookStackApp/BookStack/commit/f7ad387a10a898145845221ac3fd27df1f840c12) CSS: Updated status colors to be CSS variables, Added dark variants ### 📊 Changes **6 files changed** (+47 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `resources/sass/_blocks.scss` (+13 -13) 📝 `resources/sass/_codemirror.scss` (+1 -1) 📝 `resources/sass/_colors.scss` (+6 -6) 📝 `resources/sass/_components.scss` (+7 -7) 📝 `resources/sass/_forms.scss` (+2 -2) 📝 `resources/sass/_variables.scss` (+18 -5) </details> ### 📄 Description Needed some level of harcoding though due to callouts using colors, which can't be css colors as DOMPDF won't understand these. Use css variables elsewhere and added new dark variants to fit a bit better. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:29:40 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6338