[PR #4286] [MERGED] Comment threads #6336

New Issue

OVERLORD · 2026-02-05T10:29:35+03:00

OVERLORD commented

2026-02-05 10:29:35 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4286
Author: @ssddanbrown
Created: 6/7/2023
Status: ✅ Merged
Merged: 6/9/2023
Merged by: @ssddanbrown

Base: development ← Head: comment_threads

📝 Commits (5)

4b9f6be Comments: Updated to show as nested threads
154924c Comments: updated component and split out code
3b46b92 Comments: Updated to show form in expected location
3bede42 Comments: Added visual nesting limit, added nesting test
19e39dd Comments: Updated reply-to and general styling

📊 Changes

15 files changed (+463 additions, -270 deletions)

View changed files

📝 app/Activity/CommentRepo.php (+5 -19)
📝 app/Activity/Controllers/CommentController.php (+9 -6)
➕ app/Activity/Tools/CommentTree.php (+102 -0)
📝 app/Entities/Controllers/PageController.php (+4 -8)
📝 lang/en/entities.php (+1 -2)
📝 resources/js/components/index.js (+1 -0)
➕ resources/js/components/page-comment.js (+96 -0)
📝 resources/js/components/page-comments.js (+63 -124)
📝 resources/sass/_components.scss (+44 -13)
➕ resources/views/comments/comment-branch.blade.php (+15 -0)
📝 resources/views/comments/comment.blade.php (+62 -58)
📝 resources/views/comments/comments.blade.php (+11 -11)
📝 resources/views/comments/create.blade.php (+26 -26)
📝 resources/views/pages/show.blade.php (+3 -3)
📝 tests/Entity/CommentTest.php (+21 -0)

📄 Description

Improved layout and usage of comments and their replies.

Related to #3400

Todo

Display implementation
Update edit/create form to show in expected location.
Add some form of depth limit
Update reply indicator to now be more subtle, since mostly represented via threading.
Testing coverage

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4286 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 6/7/2023 **Status:** ✅ Merged **Merged:** 6/9/2023 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `comment_threads` --- ### 📝 Commits (5) - [`4b9f6be`](https://github.com/BookStackApp/BookStack/commit/4b9f6beb376fc6b0c31af77d96ff0842bcdd53bc) Comments: Updated to show as nested threads - [`154924c`](https://github.com/BookStackApp/BookStack/commit/154924cc0c19546599bbe1953744f9ab1162b263) Comments: updated component and split out code - [`3b46b92`](https://github.com/BookStackApp/BookStack/commit/3b46b92bb9751fe684d3c3f1cae4b942ee44b36f) Comments: Updated to show form in expected location - [`3bede42`](https://github.com/BookStackApp/BookStack/commit/3bede42121d28d7bc37d4a4318de07aaa35597f1) Comments: Added visual nesting limit, added nesting test - [`19e39dd`](https://github.com/BookStackApp/BookStack/commit/19e39ddd1f7f5fe3bef4ead24bc9090e8da58393) Comments: Updated reply-to and general styling ### 📊 Changes **15 files changed** (+463 additions, -270 deletions) <details> <summary>View changed files</summary> 📝 `app/Activity/CommentRepo.php` (+5 -19) 📝 `app/Activity/Controllers/CommentController.php` (+9 -6) ➕ `app/Activity/Tools/CommentTree.php` (+102 -0) 📝 `app/Entities/Controllers/PageController.php` (+4 -8) 📝 `lang/en/entities.php` (+1 -2) 📝 `resources/js/components/index.js` (+1 -0) ➕ `resources/js/components/page-comment.js` (+96 -0) 📝 `resources/js/components/page-comments.js` (+63 -124) 📝 `resources/sass/_components.scss` (+44 -13) ➕ `resources/views/comments/comment-branch.blade.php` (+15 -0) 📝 `resources/views/comments/comment.blade.php` (+62 -58) 📝 `resources/views/comments/comments.blade.php` (+11 -11) 📝 `resources/views/comments/create.blade.php` (+26 -26) 📝 `resources/views/pages/show.blade.php` (+3 -3) 📝 `tests/Entity/CommentTest.php` (+21 -0) </details> ### 📄 Description Improved layout and usage of comments and their replies. Related to #3400 ### Todo - [x] Display implementation - [x] Update edit/create form to show in expected location. - [x] Add some form of depth limit - [x] Update reply indicator to now be more subtle, since mostly represented via threading. - [x] Testing coverage --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:29:35 +03:00

OVERLORD closed this issue

2026-02-05 10:29:37 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6336