[PR #4254] [MERGED] Updated code view block line highlighting to only show on focus #6331

Closed
opened 2026-02-05 10:29:29 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4254
Author: @ssddanbrown
Created: 5/22/2023
Status: Merged
Merged: 5/22/2023
Merged by: @ssddanbrown

Base: developmentHead: code_active_line


📝 Commits (1)

  • 924f517 Updated code view block line highlighting to only show on focus

📊 Changes

1 file changed (+31 additions, -3 deletions)

View changed files

📝 resources/js/code/setups.js (+31 -3)

📄 Description

The default 1st line highlighting confused users when existing on read-only blocks as it was not clear this represented the active line. This changes the highlight to only show when the block is focused upon.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4254 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 5/22/2023 **Status:** ✅ Merged **Merged:** 5/22/2023 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `code_active_line` --- ### 📝 Commits (1) - [`924f517`](https://github.com/BookStackApp/BookStack/commit/924f517217399fb13aab0cf77c11071ae8f1c30e) Updated code view block line highlighting to only show on focus ### 📊 Changes **1 file changed** (+31 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `resources/js/code/setups.js` (+31 -3) </details> ### 📄 Description The default 1st line highlighting confused users when existing on read-only blocks as it was not clear this represented the active line. This changes the highlight to only show when the block is focused upon. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:29:29 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6331