starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-02-05 16:49:47 +03:00
Code Issues 784 Packages Projects Releases 10 Wiki Activity

[PR #4247] [MERGED] Revised app/ folder layout/structure #6329

New Issue
Closed
opened 2026-02-05 10:29:27 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 10:29:27 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4247
Author: @ssddanbrown
Created: 5/17/2023
Status: ✅ Merged
Merged: 5/24/2023
Merged by: @ssddanbrown

Base: development ← Head: controller_cleanup

📝 Commits (3)

  • 295cd01 Played around with a new app structure
  • 141eecb Cleaned up namespacing in routes
  • df6326e Fixed failing references after controller/file reshuffle

📊 Changes

283 files changed (+1030 additions, -1033 deletions)

View changed files

📝 app/Access/Controllers/ConfirmEmailController.php (+5 -5)
📝 app/Access/Controllers/ForgotPasswordController.php (+3 -3)
📝 app/Access/Controllers/HandlesPartialLogins.php (+3 -3)
📝 app/Access/Controllers/LoginController.php (+4 -4)
📝 app/Access/Controllers/MfaBackupCodesController.php (+7 -7)
📝 app/Access/Controllers/MfaController.php (+4 -4)
📝 app/Access/Controllers/MfaTotpController.php (+9 -9)
📝 app/Access/Controllers/OidcController.php (+4 -4)
📝 app/Access/Controllers/RegisterController.php (+5 -5)
📝 app/Access/Controllers/ResetPasswordController.php (+5 -5)
📝 app/Access/Controllers/Saml2Controller.php (+3 -3)
📝 app/Access/Controllers/SocialController.php (+5 -5)
📝 app/Access/Controllers/ThrottlesLogins.php (+1 -1)
📝 app/Access/Controllers/UserInviteController.php (+4 -4)
📝 app/Access/EmailConfirmationService.php (+2 -2)
📝 app/Access/ExternalBaseUserProvider.php (+1 -1)
📝 app/Access/GroupSyncService.php (+3 -3)
📝 app/Access/Guards/AsyncExternalBaseSessionGuard.php (+1 -1)
📝 app/Access/Guards/ExternalBaseSessionGuard.php (+2 -2)
📝 app/Access/Guards/LdapSessionGuard.php (+4 -4)

...and 80 more files

📄 Description

Just playing with a new structure for the core app code.
The primary thought of this is to split out the controllers to be closer to the logic/area for which they relate.
This makes other changes at the same time.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4247 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 5/17/2023 **Status:** ✅ Merged **Merged:** 5/24/2023 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `controller_cleanup` --- ### 📝 Commits (3) - [`295cd01`](https://github.com/BookStackApp/BookStack/commit/295cd0160525125bbd7756d7ad07392ae7201cb8) Played around with a new app structure - [`141eecb`](https://github.com/BookStackApp/BookStack/commit/141eecb858cce126452baeb16905e25b6ceb13c6) Cleaned up namespacing in routes - [`df6326e`](https://github.com/BookStackApp/BookStack/commit/df6326e5ab3aa1d31834979200309f0c8c9c133f) Fixed failing references after controller/file reshuffle ### 📊 Changes **283 files changed** (+1030 additions, -1033 deletions) <details> <summary>View changed files</summary> 📝 `app/Access/Controllers/ConfirmEmailController.php` (+5 -5) 📝 `app/Access/Controllers/ForgotPasswordController.php` (+3 -3) 📝 `app/Access/Controllers/HandlesPartialLogins.php` (+3 -3) 📝 `app/Access/Controllers/LoginController.php` (+4 -4) 📝 `app/Access/Controllers/MfaBackupCodesController.php` (+7 -7) 📝 `app/Access/Controllers/MfaController.php` (+4 -4) 📝 `app/Access/Controllers/MfaTotpController.php` (+9 -9) 📝 `app/Access/Controllers/OidcController.php` (+4 -4) 📝 `app/Access/Controllers/RegisterController.php` (+5 -5) 📝 `app/Access/Controllers/ResetPasswordController.php` (+5 -5) 📝 `app/Access/Controllers/Saml2Controller.php` (+3 -3) 📝 `app/Access/Controllers/SocialController.php` (+5 -5) 📝 `app/Access/Controllers/ThrottlesLogins.php` (+1 -1) 📝 `app/Access/Controllers/UserInviteController.php` (+4 -4) 📝 `app/Access/EmailConfirmationService.php` (+2 -2) 📝 `app/Access/ExternalBaseUserProvider.php` (+1 -1) 📝 `app/Access/GroupSyncService.php` (+3 -3) 📝 `app/Access/Guards/AsyncExternalBaseSessionGuard.php` (+1 -1) 📝 `app/Access/Guards/ExternalBaseSessionGuard.php` (+2 -2) 📝 `app/Access/Guards/LdapSessionGuard.php` (+4 -4) _...and 80 more files_ </details> ### 📄 Description Just playing with a new structure for the core app code. The primary thought of this is to split out the controllers to be closer to the logic/area for which they relate. This makes other changes at the same time. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:29:27 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6329
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?