[PR #4204] [MERGED] Added max-width to videos to prevent them escaping the page content area #6323

New Issue

OVERLORD · 2026-02-05T10:29:17+03:00

OVERLORD commented

2026-02-05 10:29:17 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4204
Author: @snowc0de
Created: 4/27/2023
Status: ✅ Merged
Merged: 4/27/2023
Merged by: @ssddanbrown

Base: development ← Head: development

📝 Commits (3)

d6b94c6 Adding a video { width: 100%; }
143f9aa Reverting precedent commit
c72d85a Adding a video { max-width: 100% } instead

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 resources/sass/_pages.scss (+5 -1)

📄 Description

This is to prevent that videos included in pages don't exceed the page border. This is to avoid the following issue:

Which now becomes this:

I didn't build the project and only added the CSS code into my instance's "head config" but as far as I know this fix should work.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4204 **Author:** [@snowc0de](https://github.com/snowc0de) **Created:** 4/27/2023 **Status:** ✅ Merged **Merged:** 4/27/2023 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `development` --- ### 📝 Commits (3) - [`d6b94c6`](https://github.com/BookStackApp/BookStack/commit/d6b94c619981a547a115c0a625d85775194d6f48) Adding a video { width: 100%; } - [`143f9aa`](https://github.com/BookStackApp/BookStack/commit/143f9aab26f175755efd7b233a13dc5c7a3fd994) Reverting precedent commit - [`c72d85a`](https://github.com/BookStackApp/BookStack/commit/c72d85a7b07f84be20d5731abc95be79b689be80) Adding a video { max-width: 100% } instead ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `resources/sass/_pages.scss` (+5 -1) </details> ### 📄 Description This is to prevent that videos included in pages don't exceed the page border. This is to avoid the following issue: ![image](https://user-images.githubusercontent.com/33733474/234785320-5175b788-cc47-4285-94e3-98809420d928.png) Which now becomes this: ![image](https://user-images.githubusercontent.com/33733474/234785481-c46a24ad-7809-416d-aa29-bbb05e4cc2d5.png) I didn't build the project and only added the CSS code into my instance's "head config" but as far as I know this fix should work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:29:17 +03:00

OVERLORD closed this issue

2026-02-05 10:29:23 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6323