[PR #4062] [MERGED] Changed the way settings are loaded #6298

New Issue

OVERLORD · 2026-02-05T10:28:48+03:00

OVERLORD commented

2026-02-05 10:28:48 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4062
Author: @ssddanbrown
Created: 2/24/2023
Status: ✅ Merged
Merged: 2/24/2023
Merged by: @ssddanbrown

Base: development ← Head: settings_perf

📝 Commits (1)

8bebea4 Changed the way settings are loaded

📊 Changes

2 files changed (+85 additions, -56 deletions)

View changed files

📝 app/Settings/SettingService.php (+80 -56)
📝 tests/Commands/UpdateUrlCommandTest.php (+5 -0)

📄 Description

This new method batch-loads them from the database, and removes the cache-layer with the intention that a couple of batch fetches from the DB is more efficient than hitting the cache each time.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4062 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 2/24/2023 **Status:** ✅ Merged **Merged:** 2/24/2023 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `settings_perf` --- ### 📝 Commits (1) - [`8bebea4`](https://github.com/BookStackApp/BookStack/commit/8bebea4ccadbf3ff40fd836a1017cbc2ae474eca) Changed the way settings are loaded ### 📊 Changes **2 files changed** (+85 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `app/Settings/SettingService.php` (+80 -56) 📝 `tests/Commands/UpdateUrlCommandTest.php` (+5 -0) </details> ### 📄 Description This new method batch-loads them from the database, and removes the cache-layer with the intention that a couple of batch fetches from the DB is more efficient than hitting the cache each time. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:28:48 +03:00

OVERLORD closed this issue

2026-02-05 10:28:50 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6298