[PR #4032] [MERGED] Generate favicon.ico file #6294

New Issue

OVERLORD · 2026-02-05T10:28:42+03:00

OVERLORD commented

2026-02-05 10:28:42 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4032
Author: @ssddanbrown
Created: 2/9/2023
Status: ✅ Merged
Merged: 2/10/2023
Merged by: @ssddanbrown

Base: development ← Head: favicon

📝 Commits (6)

420f89a Built custom favicon.ico file creator
1a18964 Integrated favicon handler with correct files & actions
2845e00 Got favicons better supported, can't get transparency right
48f1934 Updated favicon gen to use png-based ICO
da42fc7 Added default favicon creation upon access.
f333db8 Added control-upon-access of the default favicon.ico file

📊 Changes

8 files changed (+159 additions, -5 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 app/Http/Controllers/HomeController.php (+12 -0)
📝 app/Settings/AppSettingsStore.php (+9 -5)
➕ app/Uploads/FaviconHandler.php (+110 -0)
📝 public/icon.ico (+0 -0)
📝 routes/web.php (+1 -0)
📝 tests/PublicActionTest.php (+12 -0)
📝 tests/Settings/SettingsTest.php (+14 -0)

📄 Description

Followed wikipedia-defined ICO file format info, and used with Intervention's good bmp support, to create a working proof-of-concept. Just need to finish off and integrate.

Todo

Todos in code comments.
Would be ideal to confirm the incoming bitmaps will always be 32bit-per-pixel.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4032 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 2/9/2023 **Status:** ✅ Merged **Merged:** 2/10/2023 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `favicon` --- ### 📝 Commits (6) - [`420f89a`](https://github.com/BookStackApp/BookStack/commit/420f89af99dab5eedda84f9d5df5e5d63d835420) Built custom favicon.ico file creator - [`1a18964`](https://github.com/BookStackApp/BookStack/commit/1a189640f10c91eb3c519837e4228d5eb955517a) Integrated favicon handler with correct files & actions - [`2845e00`](https://github.com/BookStackApp/BookStack/commit/2845e0003ed3a7960257ef19b139627ee69523dc) Got favicons better supported, can't get transparency right - [`48f1934`](https://github.com/BookStackApp/BookStack/commit/48f1934387b7a0fb1481182374285a161d96896f) Updated favicon gen to use png-based ICO - [`da42fc7`](https://github.com/BookStackApp/BookStack/commit/da42fc7457fe076442351d2a8250bfb8c898674e) Added default favicon creation upon access. - [`f333db8`](https://github.com/BookStackApp/BookStack/commit/f333db8e4f7bd164479f7cf437696345f1e52acc) Added control-upon-access of the default favicon.ico file ### 📊 Changes **8 files changed** (+159 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `app/Http/Controllers/HomeController.php` (+12 -0) 📝 `app/Settings/AppSettingsStore.php` (+9 -5) ➕ `app/Uploads/FaviconHandler.php` (+110 -0) 📝 `public/icon.ico` (+0 -0) 📝 `routes/web.php` (+1 -0) 📝 `tests/PublicActionTest.php` (+12 -0) 📝 `tests/Settings/SettingsTest.php` (+14 -0) </details> ### 📄 Description Followed wikipedia-defined ICO file format info, and used with Intervention's good bmp support, to create a working proof-of-concept. Just need to finish off and integrate. #### Todo - [x] Todos in code comments. - [ ] Would be ideal to confirm the incoming bitmaps will always be 32bit-per-pixel. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:28:42 +03:00

OVERLORD closed this issue

2026-02-05 10:28:43 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6294