[PR #4049] [MERGED] Shelf book sort improvements #6292

Closed
opened 2026-02-05 10:28:40 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4049
Author: @ssddanbrown
Created: 2/17/2023
Status: Merged
Merged: 2/17/2023
Merged by: @ssddanbrown

Base: developmentHead: shelf_book_sort_updates


📝 Commits (3)

  • 71a09bc Started accessible controls for shelf book sort
  • 9c26ccf Added shelf book item sort action functionality
  • f799c9b Applied shelf book sort changes from testing

📊 Changes

8 files changed (+207 additions, -97 deletions)

View changed files

📝 app/Http/Controllers/BookshelfController.php (+2 -2)
resources/icons/add-small.svg (+1 -0)
resources/icons/remove.svg (+1 -0)
📝 resources/js/components/shelf-sort.js (+69 -12)
📝 resources/sass/_components.scss (+85 -0)
📝 resources/sass/styles.scss (+0 -65)
📝 resources/views/shelves/parts/form.blade.php (+31 -18)
resources/views/shelves/parts/shelf-sort-book-item.blade.php (+18 -0)

📄 Description

PR to focus on #2050 and #4031.

Todo

  • Test with screenreader.
  • Test in other browsers.
  • Double check in dark mode.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4049 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 2/17/2023 **Status:** ✅ Merged **Merged:** 2/17/2023 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `shelf_book_sort_updates` --- ### 📝 Commits (3) - [`71a09bc`](https://github.com/BookStackApp/BookStack/commit/71a09bcf6eff97ae2017510d30bef8db37406d3c) Started accessible controls for shelf book sort - [`9c26ccf`](https://github.com/BookStackApp/BookStack/commit/9c26ccf43da7674f1e137737193a4ec9fa93d84d) Added shelf book item sort action functionality - [`f799c9b`](https://github.com/BookStackApp/BookStack/commit/f799c9b260e7b0edf98fdf3f40c72199a0537d7f) Applied shelf book sort changes from testing ### 📊 Changes **8 files changed** (+207 additions, -97 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/BookshelfController.php` (+2 -2) ➕ `resources/icons/add-small.svg` (+1 -0) ➕ `resources/icons/remove.svg` (+1 -0) 📝 `resources/js/components/shelf-sort.js` (+69 -12) 📝 `resources/sass/_components.scss` (+85 -0) 📝 `resources/sass/styles.scss` (+0 -65) 📝 `resources/views/shelves/parts/form.blade.php` (+31 -18) ➕ `resources/views/shelves/parts/shelf-sort-book-item.blade.php` (+18 -0) </details> ### 📄 Description PR to focus on #2050 and #4031. ### Todo - [x] Test with screenreader. - [x] Test in other browsers. - [x] Double check in dark mode. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:28:40 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6292