[PR #3994] [MERGED] Added ability to control app icon (favicon) via settings #6286

New Issue

OVERLORD · 2026-02-05T10:28:30+03:00

OVERLORD commented

2026-02-05 10:28:30 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/3994
Author: @ssddanbrown
Created: 1/25/2023
Status: ✅ Merged
Merged: 1/25/2023
Merged by: @ssddanbrown

Base: development ← Head: app_icon_setting

📝 Commits (3)

55b6a78 Added ability to control app icon (favicon) via settings
3c658e3 Extracted app icon text, fixed issues
a50b0ea Covered app icon setting with testing

📊 Changes

12 files changed (+186 additions, -45 deletions)

View changed files

📝 app/Http/Controllers/SettingController.php (+5 -31)
➕ app/Settings/AppSettingsStore.php (+91 -0)
📝 app/Settings/SettingService.php (+4 -8)
📝 app/Uploads/ImageRepo.php (+11 -4)
➕ public/icon-128.png (+0 -0)
➕ public/icon-32.png (+0 -0)
➕ public/icon-64.png (+0 -0)
➕ public/icon.png (+0 -0)
📝 resources/lang/en/settings.php (+3 -1)
📝 resources/views/layouts/base.blade.php (+10 -1)
📝 resources/views/settings/customization.blade.php (+16 -0)
📝 tests/Settings/SettingsTest.php (+46 -0)

📄 Description

Also extracts settings update work to its own class.

Related to #3929, #301

Todo

Extract text to translations
Cover with testing
Manually test on devices

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/3994 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 1/25/2023 **Status:** ✅ Merged **Merged:** 1/25/2023 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `app_icon_setting` --- ### 📝 Commits (3) - [`55b6a78`](https://github.com/BookStackApp/BookStack/commit/55b6a7842ed8eda41637d3a26f0f7f23c0866478) Added ability to control app icon (favicon) via settings - [`3c658e3`](https://github.com/BookStackApp/BookStack/commit/3c658e39abe32a7dc345f3c49ea012340d4427e2) Extracted app icon text, fixed issues - [`a50b0ea`](https://github.com/BookStackApp/BookStack/commit/a50b0ea1e5b3e3c02aacef653a8e3dd5d09eabd8) Covered app icon setting with testing ### 📊 Changes **12 files changed** (+186 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/SettingController.php` (+5 -31) ➕ `app/Settings/AppSettingsStore.php` (+91 -0) 📝 `app/Settings/SettingService.php` (+4 -8) 📝 `app/Uploads/ImageRepo.php` (+11 -4) ➕ `public/icon-128.png` (+0 -0) ➕ `public/icon-32.png` (+0 -0) ➕ `public/icon-64.png` (+0 -0) ➕ `public/icon.png` (+0 -0) 📝 `resources/lang/en/settings.php` (+3 -1) 📝 `resources/views/layouts/base.blade.php` (+10 -1) 📝 `resources/views/settings/customization.blade.php` (+16 -0) 📝 `tests/Settings/SettingsTest.php` (+46 -0) </details> ### 📄 Description Also extracts settings update work to its own class. Related to #3929, #301 ### Todo - [x] Extract text to translations - [x] Cover with testing - [x] Manually test on devices --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:28:30 +03:00

OVERLORD closed this issue

2026-02-05 10:28:32 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6286