[PR #3821] [MERGED] Revision of item list views #6265

Closed
opened 2026-02-05 10:28:04 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/3821
Author: @ssddanbrown
Created: 10/29/2022
Status: Merged
Merged: 11/3/2022
Merged by: @ssddanbrown

Base: developmentHead: list_reworks


📝 Commits (10+)

  • 986346a Redesigned users list to be responsive and aligned
  • 0ef06fd Extracted user list item to its own template
  • 98b59a1 Revised role index list to align with user list
  • f75091a Revised webhooks list to new format
  • ec4cbbd Refactored common list handling operations to new class
  • 2c114e1 Split out user controller preference methods to new controller
  • ab184c0 Updated API tokens list to new responsive format
  • 2bbf7b2 Revised audit log list to new responsive format
  • be320c5 Adjusted audit log row spacing a tad
  • 09f2bc2 Removed addition detail spacing in audit list

📊 Changes

64 files changed (+1155 additions, -902 deletions)

View changed files

📝 .github/workflows/analyse-php.yml (+2 -2)
📝 .github/workflows/test-migrations.yml (+2 -2)
📝 .github/workflows/test-php.yml (+2 -2)
app/Actions/Queries/WebhooksAllPaginatedAndSorted.php (+30 -0)
📝 app/Actions/TagRepo.php (+9 -2)
app/Auth/Queries/RolesAllPaginatedAndSorted.php (+35 -0)
📝 app/Auth/Queries/UsersAllPaginatedAndSorted.php (+10 -9)
📝 app/Auth/Role.php (+0 -8)
📝 app/Http/Controllers/AuditLogController.php (+26 -20)
📝 app/Http/Controllers/BookController.php (+9 -6)
📝 app/Http/Controllers/BookshelfController.php (+16 -15)
📝 app/Http/Controllers/HomeController.php (+9 -13)
📝 app/Http/Controllers/PageRevisionController.php (+16 -7)
📝 app/Http/Controllers/RoleController.php (+19 -12)
📝 app/Http/Controllers/TagController.php (+12 -8)
📝 app/Http/Controllers/UserController.php (+15 -149)
app/Http/Controllers/UserPreferencesController.php (+134 -0)
📝 app/Http/Controllers/WebhookController.php (+17 -6)
app/Util/SimpleListOptions.php (+104 -0)
📝 resources/js/components/entity-permissions.js (+1 -1)

...and 44 more files

📄 Description

Primary goal is to bring a new responsive approach to existing tabular lists in the system, allowing much better mobile usage, while aligning the design approach across such lists.

Includes the following:

  • Revises users list
    • Now saves sort/order preference.
  • Revises roles list
    • Adds searching & sorting.
    • Adds display of permissions assigned.
  • Revises webhooks list
    • Adds searching & sorting.
  • Revises API tokens list
  • Aligns logical handling of common list options through new SimpleListOptions class.
  • Revises audit log list
  • Revises tags list
    • Adds sorting by name or tag usage count.
  • Revises recycle bin list
  • Revises revision list
    • Allows change of ordering (desc <=> asc)
  • Revises search term lists
  • Revises role asset permission table.

Todo

  • Align usage/creation of $listDetails across controllers.
  • /tags overview list.
  • Page revisions list
  • Audit log list
  • Recycle bin list

Closes #3638


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/3821 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 10/29/2022 **Status:** ✅ Merged **Merged:** 11/3/2022 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `list_reworks` --- ### 📝 Commits (10+) - [`986346a`](https://github.com/BookStackApp/BookStack/commit/986346a0e9de839ac876cf74c2b9e7d15da43d9b) Redesigned users list to be responsive and aligned - [`0ef06fd`](https://github.com/BookStackApp/BookStack/commit/0ef06fd29845de2b567459442c63c52dd65f24b5) Extracted user list item to its own template - [`98b59a1`](https://github.com/BookStackApp/BookStack/commit/98b59a10249afeccbf25bdd5eadf35f43a19cf67) Revised role index list to align with user list - [`f75091a`](https://github.com/BookStackApp/BookStack/commit/f75091a1c5d505f256ad253c5038a5bde068bc4e) Revised webhooks list to new format - [`ec4cbbd`](https://github.com/BookStackApp/BookStack/commit/ec4cbbd0041122f30d13afc016f8a5fac72e0754) Refactored common list handling operations to new class - [`2c114e1`](https://github.com/BookStackApp/BookStack/commit/2c114e1a4aaad9fdea2b13b5dddb583b1ebc64cb) Split out user controller preference methods to new controller - [`ab184c0`](https://github.com/BookStackApp/BookStack/commit/ab184c01d8648b86ac33d57ea5df57100aeef6f8) Updated API tokens list to new responsive format - [`2bbf7b2`](https://github.com/BookStackApp/BookStack/commit/2bbf7b2194237a82cee722bb9b936ceeaae78241) Revised audit log list to new responsive format - [`be320c5`](https://github.com/BookStackApp/BookStack/commit/be320c55012b105415bf5202acbfef2ab102c792) Adjusted audit log row spacing a tad - [`09f2bc2`](https://github.com/BookStackApp/BookStack/commit/09f2bc28d2360670e34c01cb1906f0ba92bebf4a) Removed addition detail spacing in audit list ### 📊 Changes **64 files changed** (+1155 additions, -902 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/analyse-php.yml` (+2 -2) 📝 `.github/workflows/test-migrations.yml` (+2 -2) 📝 `.github/workflows/test-php.yml` (+2 -2) ➕ `app/Actions/Queries/WebhooksAllPaginatedAndSorted.php` (+30 -0) 📝 `app/Actions/TagRepo.php` (+9 -2) ➕ `app/Auth/Queries/RolesAllPaginatedAndSorted.php` (+35 -0) 📝 `app/Auth/Queries/UsersAllPaginatedAndSorted.php` (+10 -9) 📝 `app/Auth/Role.php` (+0 -8) 📝 `app/Http/Controllers/AuditLogController.php` (+26 -20) 📝 `app/Http/Controllers/BookController.php` (+9 -6) 📝 `app/Http/Controllers/BookshelfController.php` (+16 -15) 📝 `app/Http/Controllers/HomeController.php` (+9 -13) 📝 `app/Http/Controllers/PageRevisionController.php` (+16 -7) 📝 `app/Http/Controllers/RoleController.php` (+19 -12) 📝 `app/Http/Controllers/TagController.php` (+12 -8) 📝 `app/Http/Controllers/UserController.php` (+15 -149) ➕ `app/Http/Controllers/UserPreferencesController.php` (+134 -0) 📝 `app/Http/Controllers/WebhookController.php` (+17 -6) ➕ `app/Util/SimpleListOptions.php` (+104 -0) 📝 `resources/js/components/entity-permissions.js` (+1 -1) _...and 44 more files_ </details> ### 📄 Description Primary goal is to bring a new responsive approach to existing tabular lists in the system, allowing much better mobile usage, while aligning the design approach across such lists. Includes the following: - Revises users list - Now saves sort/order preference. - Revises roles list - Adds searching & sorting. - Adds display of permissions assigned. - Revises webhooks list - Adds searching & sorting. - Revises API tokens list - Aligns logical handling of common list options through new `SimpleListOptions` class. - Revises audit log list - Revises tags list - Adds sorting by name or tag usage count. - Revises recycle bin list - Revises revision list - Allows change of ordering (desc <=> asc) - Revises search term lists - Revises role asset permission table. ### Todo - [x] Align usage/creation of `$listDetails` across controllers. - [x] `/tags` overview list. - [x] Page revisions list - [x] Audit log list - [x] Recycle bin list --- Closes #3638 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:28:04 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6265