mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-06 17:19:39 +03:00
Closed
opened 2026-02-05 10:28:03 +03:00 by OVERLORD
·
0 comments
No Branch/Tag Specified
development
further_theme_development
l10n_development
release
llm_only
vectors
v25-11
docker_env
drawio_rendering
user_permissions
ldap_host_failover
svg_image
prosemirror
captcha_example
fix/video-export
v25.12.3
v25.12.2
v25.12.1
v25.12
v25.11.6
v25.11.5
v25.11.4
v24.11.4
v25.11.3
v25.11.2
v25.11.1
v25.11
v25.07.3
v25.07.2
v25.07.1
v25.07
v25.05.2
v25.05.1
v25.05
v25.02.5
v25.02.4
v25.02.3
v25.02.2
v25.02.1
v25.02
v24.12.1
v24.12
v24.10.3
v24.10.2
v24.10.1
v24.10
v24.05.4
v24.05.3
v24.05.2
v24.05.1
v24.05
v24.02.3
v24.02.2
v24.02.1
v24.02
v23.12.3
v23.12.2
v23.12.1
v23.12
v23.10.4
v23.10.3
v23.10.2
v23.10.1
v23.10
v23.08.3
v23.08.2
v23.08.1
v23.08
v23.06.2
v23.06.1
v23.06
v23.05.2
v23.05.1
v23.05
v23.02.3
v23.02.2
v23.02.1
v23.02
v23.01.1
v23.01
v22.11.1
v22.11
v22.10.2
v22.10.1
v22.10
v22.09.1
v22.09
v22.07.3
v22.07.2
v22.07.1
v22.07
v22.06.2
v22.06.1
v22.06
v22.04.2
v22.04.1
v22.04
v22.03.1
v22.03
v22.02.3
v22.02.2
v22.02.1
v22.02
v21.12.5
v21.12.4
v21.12.3
v21.12.2
v21.12.1
v21.12
v21.11.3
v21.11.2
v21.11.1
v21.11
v21.10.3
v21.10.2
v21.10.1
v21.10
v21.08.6
v21.08.5
v21.08.4
v21.08.3
v21.08.2
v21.08.1
v21.08
v21.05.4
v21.05.3
v21.05.2
v21.05.1
v21.05
v21.04.6
v21.04.5
v21.04.4
v21.04.3
v21.04.2
v21.04.1
v21.04
v0.31.8
v0.31.7
v0.31.6
v0.31.5
v0.31.4
v0.31.3
v0.31.2
v0.31.1
v0.31.0
v0.30.7
v0.30.6
v0.30.5
v0.30.4
v0.30.3
v0.30.2
v0.30.1
v0.30.0
v0.29.3
v0.29.2
v0.29.1
v0.29.0
v0.28.3
v0.28.2
v0.28.1
v0.28.0
v0.27.5
v0.27.4
v0.27.3
v0.27.2
v0.27.1
v0.27
v0.26.4
v0.26.3
v0.26.2
v0.26.1
v0.26.0
v0.25.5
v0.25.4
v0.25.3
v0.25.2
v0.25.1
v0.25.0
v0.24.3
v0.24.2
v0.24.1
v0.24.0
v0.23.2
v0.23.1
v0.23.0
v0.22.0
v0.21.0
v0.20.3
v0.20.2
v0.20.1
v0.20.0
v0.19.0
v0.18.5
v0.18.4
v0.18.3
v0.18.2
v0.18.1
v0.18.0
v0.17.4
v0.17.3
v0.17.2
v0.17.1
v0.17.0
v0.16.3
v0.16.2
v0.16.1
v0.16.0
v0.15.3
v0.15.2
v0.15.1
v0.15.0
v0.14.3
v0.14.2
v0.14.1
v0.14.0
v0.13.1
v0.13.0
v0.12.2
v0.12.1
v0.12.0
v0.11.2
v0.11.1
v0.11.0
v0.10.0
v0.9.3
v0.9.2
v0.9.1
v0.9.0
v0.8.2
v0.8.1
v0.8.0
v0.7.6
v0.7.5
v0.7.4
v0.7.3
0.7.2
v.0.7.1
v0.7.0
v0.6.3
v0.6.2
v0.6.1
v0.6.0
v0.5.0
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/BookStack#6264
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/BookStackApp/BookStack/pull/3783
Author: @axelrindle
Created: 10/14/2022
Status: ❌ Closed
Base:
development← Head:feature/backup📝 Commits (2)
336bd22Configure automated backups6cb19cbInclude version file📊 Changes
30 files changed (+1331 additions, -1 deletions)
View changed files
📝
.env.example(+10 -0)📝
.env.example.complete(+3 -0)➕
app/Config/backup.php(+269 -0)📝
app/Config/filesystems.php(+6 -0)📝
composer.json(+1 -0)📝
composer.lock(+202 -1)➕
resources/lang/vendor/backup/ar/notifications.php(+35 -0)➕
resources/lang/vendor/backup/cs/notifications.php(+35 -0)➕
resources/lang/vendor/backup/da/notifications.php(+35 -0)➕
resources/lang/vendor/backup/de/notifications.php(+35 -0)➕
resources/lang/vendor/backup/en/notifications.php(+35 -0)➕
resources/lang/vendor/backup/es/notifications.php(+35 -0)➕
resources/lang/vendor/backup/fa/notifications.php(+35 -0)➕
resources/lang/vendor/backup/fi/notifications.php(+35 -0)➕
resources/lang/vendor/backup/fr/notifications.php(+35 -0)➕
resources/lang/vendor/backup/hi/notifications.php(+35 -0)➕
resources/lang/vendor/backup/id/notifications.php(+35 -0)➕
resources/lang/vendor/backup/it/notifications.php(+35 -0)➕
resources/lang/vendor/backup/ja/notifications.php(+35 -0)➕
resources/lang/vendor/backup/nl/notifications.php(+35 -0)...and 10 more files
📄 Description
Description
spatie/laravel-backup is a package for automated backup creation.
The default configuration includes the following data in a backup:
public/uploadsstorage/uploads.envI incorporated the data mentioned in the docs.
This does not add any possibility to create backups from the UI. Backups can be created by running the following Artisan command:
If the user wishes he may create a database-only backup:
I like this package because it lets me create backups with ease and without having to deal with custom scripts. And I'm lazy
¯\_(ツ)_/¯Points to discuss
Configuration
The package is highly configurable and I already changed some of the defaults, for example the following:
336bd22046/app/Config/backup.php (L119-L122)In my eyes the biggest point to discuss is: should there be anything else to configure via environment variables? I'd say no to keep the complexity of the config file small.
Restore
The package does not provide the possibility to restore backups which still leaves that up to the user.
I agree with that.
Resources
The packages published a lot of language resources. I'm currently questioning whether they should reside in the application's resources as I don't think there will be any changes to them.
Relations
I read through the comments in #185, #723 and #2405.
Closes #723, closes #2405.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.