[PR #3745] [MERGED] Review and refactor of auth controller components #6255

New Issue

OVERLORD · 2026-02-05T10:27:48+03:00

OVERLORD commented

2026-02-05 10:27:48 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/3745
Author: @ssddanbrown
Created: 9/22/2022
Status: ✅ Merged
Merged: 9/27/2022
Merged by: @ssddanbrown

Base: development ← Head: auth_review

📝 Commits (4)

7165481 Updated auth controllers with property types
f4388d5 Removed usage of laravel/ui dependency
90b4257 Split out registration and pw-reset tests methods
5c5ea64 Added login throttling test, updated reset-pw test method names

📊 Changes

16 files changed (+530 additions, -548 deletions)

View changed files

📝 app/Auth/Access/LoginService.php (+2 -0)
📝 app/Auth/UserRepo.php (+3 -2)
📝 app/Http/Controllers/Auth/ConfirmEmailController.php (+3 -3)
📝 app/Http/Controllers/Auth/ForgotPasswordController.php (+9 -14)
📝 app/Http/Controllers/Auth/LoginController.php (+55 -112)
📝 app/Http/Controllers/Auth/RegisterController.php (+8 -51)
📝 app/Http/Controllers/Auth/ResetPasswordController.php (+57 -35)
📝 app/Http/Controllers/Auth/Saml2Controller.php (+1 -1)
📝 app/Http/Controllers/Auth/SocialController.php (+4 -4)
➕ app/Http/Controllers/Auth/ThrottlesLogins.php (+92 -0)
📝 app/Http/Controllers/Auth/UserInviteController.php (+4 -3)
📝 composer.json (+0 -1)
📝 composer.lock (+1 -62)
📝 tests/Auth/AuthTest.php (+13 -260)
➕ tests/Auth/RegistrationTest.php (+177 -0)
➕ tests/Auth/ResetPasswordTest.php (+101 -0)

📄 Description

For #3627

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/3745 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 9/22/2022 **Status:** ✅ Merged **Merged:** 9/27/2022 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `auth_review` --- ### 📝 Commits (4) - [`7165481`](https://github.com/BookStackApp/BookStack/commit/71654810756f3be977359e5fdcd79375aab47c52) Updated auth controllers with property types - [`f4388d5`](https://github.com/BookStackApp/BookStack/commit/f4388d5e4a6353f6f79e03c638ed2971fbf48c54) Removed usage of laravel/ui dependency - [`90b4257`](https://github.com/BookStackApp/BookStack/commit/90b4257889a5f9a63ee5d9934e90557e67ebca56) Split out registration and pw-reset tests methods - [`5c5ea64`](https://github.com/BookStackApp/BookStack/commit/5c5ea642285751c322d9cf384950a5c7d6cd851f) Added login throttling test, updated reset-pw test method names ### 📊 Changes **16 files changed** (+530 additions, -548 deletions) <details> <summary>View changed files</summary> 📝 `app/Auth/Access/LoginService.php` (+2 -0) 📝 `app/Auth/UserRepo.php` (+3 -2) 📝 `app/Http/Controllers/Auth/ConfirmEmailController.php` (+3 -3) 📝 `app/Http/Controllers/Auth/ForgotPasswordController.php` (+9 -14) 📝 `app/Http/Controllers/Auth/LoginController.php` (+55 -112) 📝 `app/Http/Controllers/Auth/RegisterController.php` (+8 -51) 📝 `app/Http/Controllers/Auth/ResetPasswordController.php` (+57 -35) 📝 `app/Http/Controllers/Auth/Saml2Controller.php` (+1 -1) 📝 `app/Http/Controllers/Auth/SocialController.php` (+4 -4) ➕ `app/Http/Controllers/Auth/ThrottlesLogins.php` (+92 -0) 📝 `app/Http/Controllers/Auth/UserInviteController.php` (+4 -3) 📝 `composer.json` (+0 -1) 📝 `composer.lock` (+1 -62) 📝 `tests/Auth/AuthTest.php` (+13 -260) ➕ `tests/Auth/RegistrationTest.php` (+177 -0) ➕ `tests/Auth/ResetPasswordTest.php` (+101 -0) </details> ### 📄 Description For #3627 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:27:48 +03:00

OVERLORD closed this issue

2026-02-05 10:27:50 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6255